? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
28 Aug 2016

Summary of Changes

The frontend supports overriding the active template by passing a template= query parameter. However, when this is passed, only the template name is overridden, ignoring all other data associated with the template (i.e. its params). This is also inconsistent with our fallback behavior onto Beez3 when the specified or configured template cannot be found which does use that template's full configuration object. This is corrected.

Testing Instructions

Pre-patch, with Protostar as the active template, make a request to index.php?template=beez3 and in the Beez3 index.php file add this line: var_dump($this->params)

You should have the Protostar template's parameters here. Apply the patch and refresh the page, you should now have the Beez3 template's parameters.

Documentation Changes Required

N/A

avatar mbabker mbabker - open - 28 Aug 2016
avatar mbabker mbabker - change - 28 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2016
Labels Added: ?
avatar veronikapatel veronikapatel - test_item - 29 Aug 2016 - Tested successfully
avatar veronikapatel
veronikapatel - comment - 29 Aug 2016

I have tested this item successfully on a0a1bb2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11826.

avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016
avatar bhavikTailored bhavikTailored - test_item - 29 Aug 2016 - Tested successfully
avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016

I have tested this item successfully on a0a1bb2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11826.

avatar brianteeman brianteeman - change - 29 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 29 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11826.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Added: ?
avatar truptikagathara truptikagathara - test_item - 29 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 29 Aug 2016

I have tested this item successfully on a0a1bb2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11826.

avatar wilsonge wilsonge - change - 29 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-29 12:35:30
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Aug 2016
avatar wilsonge wilsonge - merge - 29 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 29 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment