[#11825] - Beez3 template breaks parameter injection pulling params from JFactory
- Fixed in Code Base
- 29 Aug 2016
- Medium
- Build: staging
- # 11825
- Diff
- mbabker:param-use
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
When the application renders the template, it injects the template parameters into the JDocument instance. However, only JDocumentHtml actually stores a parameters reference. Since our templates are in scope of JDocument (aside from the error.php layout all of them are in scope of JDocumentHtml), the template should reference the injected parameters instead of issuing another call to JFactory to fetch the data. By doing so, this breaks parameter injection by not using the injected data.
Testing Instructions
The Beez3 template should continue to work with its configured parameters.
Documentation Changes Required
It should be made clear what data is made available when a template file is included in the scope of JDocumentHtml and the examples updated to support this practice.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (site) Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11825.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11825.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-29 17:28:14 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11825.