Feeling Lucky
?
?
[#11818] - Cleanup JDateTest
- Fixed in Code Base
- 28 Aug 2016
- Medium
- Build: staging
- # 11818
- Diff
- mbabker:JDateTest
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
The current test class pollutes the global state by:
- Changing the default system timezone for the process without restoring the original value
- Loading objects into
JFactorywithout resetting state - Changing the static
$formatvariable ofJDate
The current test class can be considered flaky because:
- It does not mock
JLanguageand is therefore reliant on the system environment variables; if the test class is run with a non-English language configured it would fail
The test class is rewritten to:
- Restore global state when it makes changes
- No longer extend
TestCaseDatabase; a database connection is NOT required for this test class - Inject a mock database into the
toSqltests instead of relying on a database connection fromJFactory - Instructs all tests dealing with formatting to NOT translate the values (this one is more tricky than injecting a mock language instance into
JFactory; the system mock we have by default simply returns the string it is given so it is pretty much reliant on a "real"JLanguageinstance)
Testing Instructions
Ensure the unit tests pass
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Unit Tests |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-28 00:27:26 |
| Closed_By | ⇒ | wilsonge |