"Code review" should not be an acceptable testing method... "Code review" as a testing method for PR just ends up in mistakes (ask @brianteeman haha)

Why can this not be covered by unit tests? or are they already?

"Code review" should not be an acceptable testing method... "Code review" as a testing method for PR just ends up in mistakes (ask @brianteeman haha)

As principle i agree. But for this changes. You want to test all URL schemes?

Why can this not be covered by unit tests? or are they already?

don't know, don't understand unit tests very well.

Why can this not be covered by unit tests? or are they already?

don't know, don't understand unit tests very well.

Just lean toward no on that. There are a lot of our tests that don't really test anything useful (like using Reflection to inject something to a non-public property then making sure that got injected correctly, or until PHP 7 started throwing TypeError objects tests that validated errors were raised when you used a parameter not matching the typehint on the signature).

There are a lot of our tests that don't really test anything useful

#facepalm

Still not a reason not to add "useful" tests :)

If you can figure out what's useful in the unit test suite, or even better decipher JHtmlTest::testStylesheet() and JHtmlTest::testScript(), you're doing better than me, and I've been trying to fix some of the tests for years.

I have tested this item ✅ successfully on 4f8b072

I have tested this item ✅ successfully on 4f8b072

I have tested this item ✅ successfully on 4f8b072

RTC