[#11800] - [installation] Add javascript message titles and ajax errors strings
- Fixed in Code Base
- 26 Aug 2016
- Medium
- Build: staging
- # 11800
- Diff
- andrepereiradasilva:patch-28
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Add javascript message titles and ajax errors strings to installation tempalte.
You will notice that now all installation warning, error, notices and message have title like in the rest of joomla.
Testing Instructions
Code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Installation |
You can have installation in all languages
For example you can do this
Before running the installation, open installation/localize.xml and set the following on line 3:
ar-AA
yes brian but i'm loading language files that are not part of the installationlanguage files, so the language is not yet installed in joomla.
@andrepereiradasilva Do you think it would be a better solution adding these language strings to the installation language files?
the way the installation is designed ... yes i think we need all those language files in the installation languages files. Because the language itself would only be installed later.
I will make that change
| Labels |
Added:
?
|
||
| Category | Installation | ⇒ | Installation Language & Strings |
ok done
@andrepereiradasilva can you update the description to remove the bit about loading the core lang files
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11800.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11800.
@brianteeman done
@andrepereiradasilva thanks
- I have tested successfully and attached screen shot.
-
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11800.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11800.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-26 11:53:35 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
I have Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11800.
@tomartailored This has already been merged - so either you are not testing with the current staging which you must always do or you didnt really test it but I am sure that you did didnt you
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11800.
@Bakual please check this one because at installation we don't have the languages installed yet, so (i think) al joomla core messages loaded will be in english. right?
If so, is it better to add those language strings to the installation en-GB file, i mean, instead of loading joomla core and lib language file?