? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
25 Aug 2016

Summary of Changes

Changes the message type from "message" (default) to "warning" when unable to install a language in the instalation process.

Before
image

After
image

Testing Instructions

Code review.

Documentation Changes Required

none.

avatar andrepereiradasilva andrepereiradasilva - open - 25 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 25 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Category Installation
avatar brianteeman
brianteeman - comment - 25 Aug 2016

@yvesh this is the code style I was referring to

avatar brianteeman brianteeman - test_item - 25 Aug 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Aug 2016

I have tested this item successfully on 8d9174e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11799.

avatar MATsxm MATsxm - test_item - 25 Aug 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 25 Aug 2016

I have tested this item successfully on 8d9174e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11799.

avatar yvesh
yvesh - comment - 25 Aug 2016

@brianteeman in the other case the message was enqueued with the redirect instead of using enqueueMessage directly - you could us that too, but the controller setRedirect method offers the possibility to do it more readable there.

avatar jeckodevelopment jeckodevelopment - test_item - 25 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 25 Aug 2016

I have tested this item successfully on 8d9174e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11799.

avatar jeckodevelopment jeckodevelopment - change - 25 Aug 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 25 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11799.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 25 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-25 20:25:03
Closed_By rdeutz
avatar rdeutz rdeutz - close - 25 Aug 2016
avatar rdeutz rdeutz - merge - 25 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment