As we add a plugin we need The Update SQLs, add the new plugin to the install sql, the new plugin needs to be added to the script.php and the new lanugage files needs to be added to the install.xml

We should move media/plg_content_createmenulink/copytitle.js to media/plg_content_createmenulink/js/copytitle.js and add a copytitle.min.js same for the other JS file.

@shubhamnba2009 please also see: shubhamnba2009#1

and shubhamnba2009#2 ?

see also minor change in shubhamnba2009#3

@shubhamnba2009 as @zero-24 said

As we add a plugin we need The Update SQLs, add the new plugin to the install sql, the new plugin needs to be added to the script.php and the new lanugage files needs to be added to the install.xml

You need to add the plugin to the installation sql (mysql: https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L616) and also to the update sql (mysql: https://github.com/joomla/joomla-cms/tree/staging/administrator/components/com_admin/sql/updates/mysql) in all 3 database systems.

Also you need to add them to updater so the manifest cache can be refreshed on update: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L348

We need the mssql and postgressql for the install SQL too :)

@andrepereiradasilva Have a look in the latest commit of changing queries with quoteName() and quote(), thanks :)

As we use menu item and not menu link generally speaking in Joomla, I suggest to modify the ini string values to fit.
Also we do not use Menu Name but simply Menu (see mod_menu)

@infograf768 That means I have to change the plugin name also?

I would, but I am not the only one to decide. Let's wait what others think.

i agree with @infograf768 IIRC there is no "menu link" in joomla, it's always called "menu item".
for consistency all should changed to menu item IMHO.

@shubhamnba2009 can you check my approach on the module ordering #11040? Maybe it worth a port here to menuorder field...
Just an idea

Is dis ready for commit? Any more suggestions or changes that I need to implement?

I couldnt get it to install using patchtester so I downloaded your branch to try.

that shows the plugin as being enabled but there is nothing in the article to create a menu

I had to open and save the plugin - that suggests that you are not setting the plugin params in th installation

@brianteeman
Yeah I also just checked out that after opening and saving the plugin starts to works. I have updated the installation folder before. Let me have a double check on what I left. Thanks for the heads up!!

Issue 1
1. Create an article called brian and save it with a menu item of brian
2. Create an article called john and save it with a menu item of brian
Expected result is that the article will NOT save and you will get an error that the menu exists already
Actual result is that the article is saved and you will get an error that the menu exists already

Issue 2
1. Create an article called simon and save and close
2. Re-open the article and save and close
Expected result is that the article is saved as normal
Actual result is that that the article is saved AND a menu item is created

Thats just the start. Every time I open an article I see something new. This needs a lot more work in testing what happens when you create articles AND edit existing articles ESPECIALLY if you do NOT want a menu item

For issue 2.
I had considered that user had enabled plugin with the intention to create a menu item. So if he does not want to get a menu item created he had to clear the menu title, which in fact has another fucntionality of getting auto-filled based on the article title.
So basically every time user enter the article title same title will be automatically copied to menu title. Beacuse of this functionality menu item is getting created.
So what's you suggestion. Should I remove auto-fill functionality?

YES the auto-fill cannot be on for everything - no way you would ever want to create a menu item for everything

In Joomla 1.0 it was possible to create a menu link to an article from the article edit view in the administrator back-end.

It should work like that - you have the option/ability to create a menu link from the article edit view. It should not be created automatically for everything

I like the auto-refill function (automatically copying the (article) title for the menu item) because it speeds up your workflow as you've to type less. However I did not realize that as @brianteeman describes, because the menu title was already added by auto-fill, it would always create a menu item.

Maybe we can change the feature a bit? e.g. add a checkbox or button with "copy menu item title from title" and if it's clicked then copy the title of the item to the Menu Item Title input box.

It needs to be more than that. Right now the code will always create a menu
item if there is a title. There is no positive action "create menu". There
needs to be. Its more than just how the title is created that needs looking
at it is the whole process of how a menu item is created

On 10 September 2016 at 07:54, Peter Martin notifications@github.com
wrote:

I like the auto-refill function (automatically copying the (article) title
for the menu item) because it speeds up your workflow as you've to type
less. However I did not realize that as @brianteeman
https://github.com/brianteeman describes, because the menu title was
already added by auto-fill, it would always create a menu item.

Maybe we can change the feature a bit? e.g. add a checkbox or button with
"copy menu item title from title" and if it's clicked then copy the title
of the item to the Menu Item Title input box.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11766 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ch49GOmZ9aX-E8bwfrJb-posxKuks5qolQ0gaJpZM4JrUoO
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@brianteeman I have done modifications as suggested by you. Could you please review once?

@shubhamnba2009 Thanks ?

FYI: PLT voted on merging this and motion passed.

@shubhamnba2009 and @puneet0191 can you please solve conflicts with this PR?

Please test again since this will be merged in the core.

When creating a menu item there is an option to select the parent item
I would expect this to show me a list of all the current menu items for the selected menu
Instead it shows me a list of all the menu items for all the menus and the admin menus in one single list

Agree with Brian.
The confusion also comes from the fact that there are 2 dropdown fields
One general when editing the Content: Parent Item
Another one in the Menu Item Options.
Until the article is saved AFTER choosing the Menu in the Menu Item Optiins, we then get the correct possible Parent Items, and only then.

The Menu has to be chosen first and the possible parent menu items should be displayed on the fly.
In any case, we should never display back-end menu items imho.

Another issue is that after save and close, if we re-edit the article, there is no trace of the menu item that has been created. This is prone to errors when one has many article menu items.

Not just a confusion - it is 100% wrong to show those admin component menu items

It is very easy to target only frontend menu items with a
->where($db->quoteName('a.client_id') . ' = 0')

But, for me, even after correcting this, the way it works is very confusing as parent menu items corresponding to a specific menu are not proposed on the fly and no trace remains of an article menu item already created for that article when editing the article.

@shubhamnba2009 Could you please resolve conflicts on this one?

@puneet0191 I have noticed a new check (appveyor) is integrated now. The PR is failing its check... Any idea whom should I contact to know about it?

@shubhamnba2009 Appveyor should be fine. If you can resolve the conflicts we can see what the automated tests do and we can follow up as needed.

@roland-d I resolved the conflicts.. Let me know how the automated test does :)

@shubhamnba2009 All tests passed. Thanks ?

Now we just need human test. I will get some people to test next week.

Tested this and it never populates the parent item

Further test

1. Menu title not stored in the article so no way to see if an article has a menu item
2. Menu item created as unpublished so you still need to go to the menu to publish it which defeats part of the object of this PR

This has been superceeded by #21357 and merged so closing here - thanks for all the hard work that was done here!