I have not tested this item.

- I applied your patch

• made a fresh installation with mysql_pdo
• added $this->connection->query("SET @@SESSION.sql_mode = 'STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION';"); in line 155 of the pdo-mysqldriver (although I am using mysql 5.6.28)
• and got the following error when I went to extensions > manage > install languages SQLSTATE[HY000]: General error: 1364 Field 'data' doesn't have a default value

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11763.}

hum, so it seems we have another data columns without default value ...
i bet is this one https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1765

@waader i can confirm your findings on pdo but i'm quite sure is the same mssql

@andrepereiradasilva you have opend a "Pandora's box" (pdo-mysql + mssql)

and yes your bet is winning

i'm still testing on pdo but for me the schema should be something like this:

plus

in this way i'm able to go a little forward ...
....now i'm stuck on asset_id

....

ok so the data column should be fixed now.

@andrepereiradasilva you have opend a "Pandora's box" (pdo-mysql + mssql)

i have that strange habit ?

But, IMO this PDO strict mode is a good thing because it makes all databases work in similiar way.
IMO 4.0 should only accept strict mode.

I have tested this item ✅ successfully on 2f70844

Now works for pdo_mysql and mssql. After login to the mssql instance there is another error showing up but that´s another story.

One suggestion: It would be nice to see the sqlmode in systemsinformation.

@waader did you test installing a fresh new site with multilingual enabled
and with at least 2 languages ?

On 24 Aug 2016 11:02 am, "waader" notifications@github.com wrote:

I have tested this item ✅ successfully on 2f70844
2f70844

Now works for pdo_mysql and mssql. After login to the mssql instance there
is another error showing up but that´s another story.

One suggestion: It would be nice to see the sqlmode in systemsinformation.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11763
https://issues.joomla.org/tracker/joomla-cms/11763.

—

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11763 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsUpxUDmA4Un_Z1tdjTu4XnqJMBvnks5qjAiRgaJpZM4JrHXL
.

@waader how we get the sqlmode?

@zero-24 For "PDO (MySQL)" see #9457

@alikon i tested by manually performing the alter in mysql PDO strict mode and them installing the language in the backend.

I will test install too when i have time.

BTW just notice that if you enable the finder plugins you can't even save content in PDO Mysql Strict Mode! But that is not for this PR.

Pandora's box ...

We really need a db expert checking all this PDO MySql Strict things.

Update: Added issue #11771 for this

Are you ready to start an autumn of code ?

On 24 Aug 2016 1:31 pm, "andrepereiradasilva" notifications@github.com
wrote:

BTW just notice that if you enable the finder plugins you can't even save
content in PDO Mysql Strict Mode! But that is not for this PR.
[image: image]
https://cloud.githubusercontent.com/assets/9630530/17929146/833b91da-69f6-11e6-94c1-bc3d7e271fbc.png

[image: image]
https://cloud.githubusercontent.com/assets/9630530/17929149/864f9182-69f6-11e6-8867-456e7a3097f8.png

Pandora's box ...

We really need a db expert checking all this PDO MySql Strict things.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11763 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsbjgd8kRJQ8s9H5THN1SLksTmQ7Dks5qjCt0gaJpZM4JrHXL
.

Are you ready to start an autumn of code ?

ehhehe. Not me, i'm no DB expert, but this IMO should be solved for 4.0
Joomla is bypassing the strict mode (MySql 5.6.6+ default) because of lack of consistency in joomla DB.

Maybe we should add a comment to the hack in the driver?

@alikon Yep, with three languages.

@alikon can you confirm it works now?

If you install languages when install a fresh site don't work on pdo
strict mode... I'm working on a pr that solve the issue you reported about
finder plugin enabled too... I'll update you asap...

On 25 Aug 2016 11:22 am, "andrepereiradasilva" notifications@github.com
wrote:

@alikon can you confirm it works now?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

ok should work now in pdo strict mode now

still don't work on pdo strict-mode 10.1.8-MariaDB in this way

did you miss my previous comment #11763 (comment) ?

i've submitted a fix to your branch andrepereiradasilva#67

@alikon did you tested the latest version?
I already solved that: https://github.com/joomla/joomla-cms/pull/11763/files#diff-135c6f58583408312a709459b19594c7R1765

I think so, but I'll double check

i followed this path

• downloaded the latest staging
• installed with mysql no pdo
• installed the com_patchtesterr (just in case i've not patchted correctly manually)
• applyed PR #11763 with the last changes (as it is now)
• dropped all tables in the database
• deleted the configuration.php
• added the strict mode to pdomysql.php at line 155

//$this->connection->query("SET @@SESSION.sql_mode = '';");
$this->connection->query("SET @@SESSION.sql_mode = 'STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION';");

• double checked that all changes in the PR #11763 are correctly in place
• started a new installation with mysql pdo strict mode as a database
• select the no data for basic multiligual install
• double check that PR are corretclty applyied as db schema on changed tables checked with phpmyadmin
• click on extra step install languages
• got the sql error

this is what phpmyadmin report about DB

if i repeat the same step but with andrepereiradasilva#67 applyied installation with multilgual enabled + 4 languages content menus etc goes OK

p.s.
PDO sould be considered as a different DB .... what is valid for other's DB is not valid with PDO
so this PR should be diveived in two parts one for MYSQL PDO (STRICT MODE) and one for MSSQL IMHO

don't understand repeated the exact same steps you did and don't have any issue!

could it be the mariadb version ?

andrè
it could be, but really is quite odd, what is your php version ?

• can you try mine, just to have a wide spectrum of tests...

7.0.8

i suspect your error is other data column (session table?)

https://github.com/andrepereiradasilva/joomla-cms/blob/dd5477f2e204119e9935b8e500450f073cf99383/installation/sql/mysql/joomla.sql#L1565

like someone we both knows is used to say .... hmmm ;)

i mean how can you have a data has no default value error if the column clearly has now a default value ...

`data` text NOT NULL DEFAULT '',

maybe i've overlooked at the xml language files from the update site they don't have a data field tag
long debug session is needed....
sorry for repeating can you test with #67 instead ? (looking for a lowest common denominator)

i've digged more on this issue, here is what happens on my environment when i click on extra step install languages

as you may notice the field data is not present in the INSERT field list
nor is present in the xml

<extension name="Armenian" element="pkg_hy-AM" type="package" version="3.4.4.1" detailsurl="https://update.joomla.org/language/details3/hy-AM_details.xml"/>

so why that field should have the NOT NULL constraint ?

Don't know. But the not null is on the 3 db systems

tested successfully on mysql pdo strict mode and postgresql with php 5.5
@waader can you re-test on MSSQL

I have tested this item ✅ successfully on 6e11d41

I have tested this item ✅ successfully on 6e11d41

Works with mssql!

RTC

@alikon i notice now you changed the update libraries in your PR (that was merged in this), did you test the extension updates work fine after that?

@brianteeman sorry please remove RTC until @alikon confirm this.

Done :)

The @zero-24 robot was faster

Hehe :)

i notice now you changed the update libraries in your PR (that was merged in this), did you test the extension updates work fine after that?

@andrepereiradasilva extension updates doesn't not work with PDO strict mode even without that change, i've made a fix for this scenario , see andrepereiradasilva#76 now you should be able to upgrade extensions, tested with com_patchtester and weblinks

RTC

@brianteeman since my last PR andrepereiradasilva#76 is not yet merged i suggest you to remove the RTC status....

Sorry I misread that comment

Remove RTC

@andrepereiradasilva can you evaluate my last one ...

Closing as there is a new PR to fix it #14321