[#11762] - Remove some deprecated files
- Closed
- 4 Sep 2016
- Medium
- Build: staging
- # 11762
- Diff
- brianteeman:deprecateddelete
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removes two empty files that were marked as deprecated 3.2 and adds them to the list of files to be removed on upgraded sites
Removes all the batch_body files that were marked as deprecated 3.4 and added them to the list of files to be removed on upgraded sites
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | Administration Components | ⇒ | Administration Components Tags |
| Title |
|
||||||
Applied and works4me
RTC
Is there any possibility that this will break someone's site? Bear in mind our development policy which states:
"Previously deprecated elements that are no longer used in the product itself MUST be removed in the first version of a new major series but MUST NOT be removed in a minor or patch release."
Didn't know about this policy. I think we should change it. I agree with not removing deprecated files in a patch release but it should be ok to remove in a minor release.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11762.
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11762.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11762.
We have 4 x positive test results so this should be RTC?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11762.
Quick feedback on this here. We discussed the use of the deprecated tag in combination with semver yesterday at the PLT meeting. We realised that we don't have the same understanding, so the decision was to do some research and document a policy so that it is clear what it means and how to handle it.
I am sorry but I think we need to set the state to needs review. Thank you all for working on this it has made clear that we need to define this clearer.
| Status | Pending | ⇒ | Needs Review |
I'm merging this. We don't guarentee b/c in extensions according to our policy and we are no longer using these files. If someone is overriding default.php and this file in a template then it will also continue to work. But if they are overriding just this file then as we aren't loading them they will be non-functional.....
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 15:40:05 |
| Closed_By | ⇒ | wilsonge |
Thanks
Was too fast: I guess we can solve the issues. See
#12407 (comment)
I have tested this item✅ successfully on
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11762.