Feeling Lucky
?
[#11722] - [Sql azure] Normalize update sql files
- Fixed in Code Base
- 25 Aug 2016
- Medium
- Build: staging
- # 11722
- Diff
- andrepereiradasilva:sql-azure
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Normalizes all sql azure update files.
- always use
SET IDENTITY_INSERT [#__xxxx] ON/OFF;when inserting (like joomla.sql) -
INSERTtoINSERT INTO(like joomla.sql) - Quote all table names and db field names
- Always use
'to quote string values. - Code style
Testing Instructions
Mainly code review. (easier to check code diff without white spaces changes) https://github.com/joomla/joomla-cms/pull/11722/files?w=1
If anyone could test and upgrade from 2.5.28 to 3.6.x would be great. Don't have sql azure to test,
Documentation Changes Required
None.
joomla-cms-bot
- | Category | ⇒ | SQL MS SQL Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
alikon
- comment
- 23 Aug 2016
I have tested this item
on code review still unable to test on MSSQL
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11722.
waader
- comment
- 23 Aug 2016
I have tested this item
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11722.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 23 Aug 2016
| Labels |
Added:
?
|
||
zero-24
- comment
- 23 Aug 2016
Thanks
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 11:56:33 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
The travis javascript tests error has nothing to do with this PR.
Mantainers please rerun travis here.