[#11721] - 3.7.0: New Feature=>editor-xtd to insert menu items links in content
- Fixed in Code Base
- 28 Aug 2016
- Medium
- Build: 3.7.x
- # 11721
- Diff
- infograf768:menu_editor-xtd
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Grace to the new modals for menu items, we can now add a new editor-xtd to insert menu items links in content.
Instructions:
Install a 3.7.0 (not necessary to patch first with #11694 but modal title would look better)
Patch with this PR.
Discover the new plugin. Enable it.
Edit an article or create a new one
The editor now shows a new button "Menu"
depending if the site is multilingual or not, the language will be appended to the link when the menu item is tagged to a specific content language.
By toggling the editor you should get:
<p><a href="index.php?Itemid=111">newsfeed category menu</a></p>
or
<p><a href="index.php?Itemid=107&lang=fr-FR">menu article fr-FR</a></p>
test the results in frontend.
joomla-cms-bot
- | Category | ⇒ | Administration Components SQL Postgresql MS SQL Language & Strings Installation Plugins Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
jeckodevelopment
- | Labels |
Added:
?
|
||
Changed constants and icon
Need more testers to get RTC
Thank you @infograf768
On 22 August 2016 at 14:59, infograf768 notifications@github.com wrote:
Changed constants and icon
[image: screen shot 2016-08-22 at 15 55 07]
https://cloud.githubusercontent.com/assets/869724/17857262/5654e44e-6881-11e6-93c4-b23192da88c2.pngNeed more testers to get RTC
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11721 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YZftytAadeTY00OteicTJvzp8Eeks5qiatEgaJpZM4JppD7
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
need tests on issue.joomla.org
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11721.
| Status | Pending | ⇒ | Ready to Commit |
RTC
Thanks @wilsonge for merging into 3.7.x
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11721.
| Labels |
Added:
?
|
||
after merge, we will have to add this to the xmls where the xtd plugins are disabled.
Which xmls do you mean @infograf768 ?
mod_custom, com_bannres etc. All the places that initiate an editor but the user is not supposed to be able to insert a link to a menu
The only one I would think you need to do this for would be com_banners
where the text is an admin only feature.
On 23 August 2016 at 13:59, Dimitri Grammatikogianni <
notifications@github.com> wrote:
mod_custom, com_bannres etc. All the places that initiate an editor but
the user is not supposed to be able to insert a link to a menu—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11721 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cZ2Mm6NebyBBdwn03glpEGH6cO0ks5qiu6wgaJpZM4JppD7
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Concerning hiding the editors-xtd_menu, we have
message.xml:27: hide="readmore,pagebreak,image,article,module" />
where I guess we should add it to the list
not sure about banner as article is authorised there
banner.xml:95: hide="readmore,pagebreak,module"
mod_custom is a special case as we have it both in admin and site. We will have to look at that.
the banner wysiwyg only ever displays in the admin so although you could
let someone insert a menu link it wont work
On 23 August 2016 at 17:29, infograf768 notifications@github.com wrote:
Concerning hiding the editors-xtd_menu, we have
message.xml:27: hide="readmore,pagebreak,image,article,module" />
where I guess we should add it to the list
not sure about banner as article is authorised there
banner.xml:95: hide="readmore,pagebreak,module"—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11721 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8SlXUCgVlGXHrzdlHpedlXEG-sFAks5qix_SgaJpZM4JppD7
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
the banner wysiwyg only ever displays in the admin so although you could let someone insert a menu link it wont work
I guess we therefore should correct the xml and add article to the hide list
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-28 20:34:39 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on d95c1f9
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11721.