? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
21 Aug 2016

Summary of Changes

Since #9935 we need to quote jQuery selectors.
So, this PR, quotes jQuery selectors in tabs state jquery.

Testing Instructions

Code review.

Documentation Changes Required

None.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2016
Category JavaScript
avatar andrepereiradasilva andrepereiradasilva - open - 21 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2016
Labels Added: ?
avatar ggppdk ggppdk - test_item - 21 Aug 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 21 Aug 2016

I have tested this item successfully on 31a3380

Code review and applied patch too,

e.g. quick test of article edit form, (used browser console log too), both changed activateTab(), and hasTab() work properly


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11708.

avatar C-Lodder C-Lodder - test_item - 22 Aug 2016 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 22 Aug 2016

I have tested this item successfully on 31a3380


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11708.

avatar brianteeman brianteeman - change - 22 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 22 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11708.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 22 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-22 20:05:50
Closed_By rdeutz
avatar rdeutz rdeutz - close - 22 Aug 2016
avatar rdeutz rdeutz - merge - 22 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 22 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment