[#11699] - Allow language files to be debugged without parsing them
- Fixed in Code Base
- 22 Aug 2016
- Medium
- Build: staging
- # 11699
- Diff
- mbabker:lang-debug-file-separated
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request porting joomla-framework/language@2da4017
Summary of Changes
This allows language files to be debugged without having to be loaded into JLanguage and parsed by moving the debug logic to its own method.
Testing Instructions
Triggering JFactory::getLanguage()->debugFile($file) should accurately report results if the file is good or bad.
Documentation Changes Required
N/A, the class' API is only documented by the automated API docs.
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
It's a new method, there's no B/C involved. Unless you consider that it is
called from the parse method. The parse method is only called after
verifying the file exists, so there shouldn't be an issue there.
And no, I wouldn't move it to the helper.
On Sunday, August 21, 2016, andrepereiradasilva notifications@github.com
wrote:
two questions:
1. Shouldn't debugFile method be moved to JLanguageHelper ?
2. The exception you added means that if a ini is not found and we are in
debug mode we now get an exception, right? For instance if i delete a
language folder now i get a lot of exceptions across the backend. So, the
question is: is this part B/C?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11699 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoZdpZePUTMkpPEzjqFqNMFIDSsP4ks5qiN_LgaJpZM4JpLOw
.
I have tested this item
Works as described in language debug mode.
Works as described with calls like
$errorCount = JFactory::getLanguage()->debugFile(JPATH_ADMINISTRATOR . '/language/en-GB/en-GB.com_joomlaupdate.sys.ini');
echo $errorCount;
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11699.
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11699.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11699.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-22 20:00:08 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
two questions:
1. Shouldn't
debugFilemethod be moved to JLanguageHelper ?2. The exception you added means that if a ini is not found and we are in debug mode we now get an exception, right? For instance if i delete a language folder now i get a lot of exceptions across the backend. So, the question is: is this part B/C?
Update: Forget part 2 i was with the test code still there.