[#11698] - Avoid trying to load a module's language file multiple times
- Fixed in Code Base
- 22 Aug 2016
- Medium
- Build: staging
- # 11698
- Diff
- mbabker:dupe-module-load-languages
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Depending on how many times a module gets used on a page, its language files may attempt to be loaded multiple times. Because of the internal loading of the default language, depending on where a language file is located the load method will go through at least a couple of loops resulting in a bunch of extra processing. Example:
By checking if the files have been loaded first, we can cut back on the number of loops that get made here. Example:
Testing Instructions
The module's language files are still loaded correctly.
Documentation Changes Required
N/A
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11698.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-22 19:58:50 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Maybe we need to chnage to
if (!$lang->getPaths($module->module || $app->isAdmin())) ?
Not an acceptable fix. It basically says "always load language files for an extension on the admin app, regardless of if loaded or not". The whole point of this was to reduce the number of times we're calling JLanguage::load() when an extension has already been loaded.
I have tested this item✅ successfully on a5ecc9a
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11698.