[#11681] - Fix typo in content_type in getItemTags of com_users profile view
- Closed
- 22 Aug 2016
- Medium
- Build: staging
- # 11681
- Diff
- bertmert:patch-13
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for part 1 of Issue #11666
Summary of Changes (New)
(See comments #11681 (comment) and #11681 (comment))
After some investigations I removed these lines completely:
- The line never worked correctly. No issues were reported for years. It always returns an empty array.
- Tags are not fully implemented for com_users component yet. Just rudimentary. (And by the way my opinion is that it never should get implemented when I have a look on field
#__content_types : field_mappings.). Thus this line never returns any meaningful datas.
Summary of Changes (Old/Outdated)
Correct typo in getItemTags() call. The first parameter is type_alias of DB table #__content_types.
Testing Instructions
Code review.
Tags are not implemented in user views at the moment (which is part 2 of issue #11666) .
Check if anything weird happens in user profile view in front-end after patch.
B\C ?
I don't see any issues for a line that is seneseless.
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@andrepereiradasilva Thank you.
Hm, strange. There it's wrong (returns an empty array), too, but the article edit form works fine without this line concerning tags.
I have to make some investigations where when why we need getItemTags() at all in edit views.
Sorry! After some hours of investigations I'm closing this PR because the more I try to understand the logic of com_tags the less I understand...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-22 04:55:24 |
| Closed_By | ⇒ | bertmert |
i think there is another one like this one.
See https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/form/view.html.php#L66