I have tested this item ✅ successfully on

Simple chnage. on review

I have tested this item ✅ successfully on 8b7a1cb

May I ask for a minor change here?
Since

        return JHtml::_('select.genericlist', $languages, 'lang', ' class="advancedSelect"', 'value', 'text', null);

the class is set to advancedSelect can we also set it to JHtml:_(...)?
This will prevent possible script breaks, since chosen will take control of all the select elements on the page

@dgt41 please make a patch in my andrepereiradasilva:patch-9 branch and i will check it.

@andrepereiradasilva andrepereiradasilva#66

done. merged
@dgt41 you missed the dot in your patch.

and you added a search ...

I have tested this item ✅ successfully on 8ec7c5b

While I understand it's not needed on that page there is a small
performance benefit of loading it on that lightweight page and caching it
locally before logging in and loading it on a heavier page.

I would prefer that joomla would not load chosen in the front end at all especially when it's done only for styling purposes (like in this case).

While I understand it's not needed on that page there is a small performance benefit of loading it on that lightweight page and caching it locally before logging in and loading it on a heavier page.

Brian, sorry but i don't agree with that logic. browser cache of chosen css/js files happens only one time (until cache expires) ... the first time you visit a page that uses chosen, frontend or backend.

This isnt in the front end?

On 20 August 2016 at 11:04, Dimitri Grammatikogianni <
notifications@github.com> wrote:

I would prefer that joomla would not load chosen in the front end at all
especially when it's done only for styling purposes (like in this case).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11680 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Wu5tldogm6vbun_Mf-UDz6Af1qHks5qhtEsgaJpZM4Jo9fB
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Thats exactly my point. So loading it on a lightweight page is more
efficient than loading it on a heavyweight page

On 20 August 2016 at 11:04, andrepereiradasilva notifications@github.com
wrote:

While I understand it's not needed on that page there is a small
performance benefit of loading it on that lightweight page and caching it
locally before logging in and loading it on a heavier page.

Brian, sorry but i don't agree with that logic. browser cache of chosen
css/js files happens only one time until cache expires ... the first time
you visit a page that uses chosen, frontend or backend.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11680 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WGabfl2k_vXfbmlOzJPukeR57QLks5qhtFAgaJpZM4Jo9fB
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Thats exactly my point. So loading it on a lightweight page is more
efficient than loading it on a heavyweight page

Ok so if i followed that logic i will load all joomla js and css libraries here so they are cached when i use them.
Sorry but that makes no sense to me.

Preloading is a common performance technique

On 20 August 2016 at 11:09, andrepereiradasilva notifications@github.com
wrote:

Thats exactly my point. So loading it on a lightweight page is more
efficient than loading it on a heavyweight page

Ok so if i followed that logic i will load all joomla js libraries here so
they are cached when i use them.
Sorry but that makes no sense to me.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11680 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cyT3lWht0uPdGrQa91z0gki99Rzks5qhtJegaJpZM4Jo9fB
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

yes it is in some cases, but not in this way brian.

chosen main files are chosen.jquery.min.js (26KB) and chosen.css (14KB) and are only downloaded one time by the browser that saves them in cache, this normally happens before you even have time to blink your eye ;)
and if you use a CDN, then you don't even start to blink the eye :)

actually IMO the performance problem with chosen is not the download of the css/js files is the processing of chosen js when you have a lot of elements. And that is done always, ie, in every page that uses chosen.