[#11666] - Typo 'com_users.user.' in "components\com_users\views\profile\view.html.php"
- Closed
- 6 Apr 2017
- Medium
- Build: master
- # 11666
Steps to reproduce the issue
Typo in "components\com_users\views\profile\view.html.php" that cause not working tags for com_users profile view. In the line 79 writen "$this->data->tags->getItemTags('com_users.user.', $this->data->id);" but must be "$this->data->tags->getItemTags('com_users.user', $this->data->id);" Also in default_custom.php tmpl there is no code for tags so tags fields will not work in user profile view.
Expected result
$this->data->tags->getItemTags('com_users.user', $this->data->id);
Actual result
$this->data->tags->getItemTags('com_users.user.', $this->data->id);
System information (as much as possible)
Joomla! 3.6.2
Additional comments
brianteeman
- | Labels |
Added:
?
|
||
@brianteeman i think this can be closed as we have a PR for testing
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-21 20:35:20 |
| Closed_By | ⇒ | zero-24 |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/11666
@zero-24
Could you please reopen this issue. After an additional find of @andrepereiradasilva (#11681 (comment)) I reflected to much on com_tags (not the first time in my life) to be sure what I'm doing and why. In both cases I think these lines can be removed because they are unnecessary but ???
#11681 (comment)
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-08-21 20:35:33 | ⇒ | |
| Closed_By | zero-24 | ⇒ |
Set to "open" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/11666
@bertmert both cases seems a bug to me see https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/helper/tags.php#L386
Yes I know but as I said I think these lines are completely unnecessary. When I fix the typo in com_content we get an unnecessarily populated array instead of an empty one. So, fixing the typo just to fix it and get an unnecessary overhead is not a good solution.
On the other hand I don't know if we need $this->item->tags = new JHelperTags; under some strange circumstances or if it should be removed, too.
com_users: I would prefer to remove the whole incomplete tags (un)logic from this component instead of fixing a single typo.
Means: Should be discussed (or somebody should take over).
Please don't remove this lines from com_users because I use tags for users profile. Please just fix typo.
@YHartonuk
You can provide a PR. It's really easy:
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
(I don't see a way to use tags in com_users without core hacks. Maybe I'm wrong.)
I use my custom plugin for user profile and custom com_users view for my theme so I don't use any hack for joomla core
| Category | ⇒ | Components |
@YHartonuk can you make a PR so this Issue get resolved?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11666.
| Status | New | ⇒ | Information Required |
easy pr made
maybe @YHartonuk can test with his custom extension
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-06 17:44:39 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/11666
closed as PR made, thanks @alikon
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11666.
@YHartonuk
Please test #11681
concerning typo.