? Success

User tests: Successful: Unsuccessful:

avatar AlexRed
AlexRed
19 Aug 2016

Pull Request for Issue # .

Summary of Changes

Fix in the "Featured Articles" menu item the text "More Articles ..." don't appear after some article intro (5) and the box with links to other articles.

Testing Instructions

Create 6 or more "Featured article", create the "Articles--> Featured Articles" menu item, the text "More Articles ..." don't appear after some article intro (5) and the box with links to other articles.

After the patch the text "More Articles ..." from COM_CONTENT_MORE_ARTICLES (/language/en-GB/en-GB.com_content.ini) appear.

example

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2016
Category Front End Components
avatar AlexRed AlexRed - open - 19 Aug 2016
avatar AlexRed AlexRed - change - 19 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2016
Labels Added: ?
avatar AlexRed AlexRed - change - 19 Aug 2016
The description was changed
avatar AlexRed AlexRed - edited - 19 Aug 2016
avatar AlexRed AlexRed - change - 19 Aug 2016
The description was changed
avatar AlexRed AlexRed - edited - 19 Aug 2016
avatar AlexRed
AlexRed - comment - 19 Aug 2016

I updated the PR by editing the file also for the "Articles » Category Blog" menu item

avatar brianteeman
brianteeman - comment - 19 Aug 2016

Is this really a bug? The beez template was only using this for "increased" accessibility

avatar AlexRed
AlexRed - comment - 19 Aug 2016

in this way it also appears in all other templates (that have not override for these files) and not only for those uses beez.
But if for you the language string is only for beez template, ok. Close my PR.

avatar brianteeman
brianteeman - comment - 19 Aug 2016

Unless I made a mistake it only appears in the template override for beez

On 19 August 2016 at 11:57, Alessandro Rossi notifications@github.com
wrote:

in this way it also appears in all other templates (that have not override
for these files) and not only for those uses beez.
But if for you the language string is only for beez template, ok. Close my
PR.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11665 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VJfXnyGu_wU2EsPaCuNyR_VcTZ-ks5qhYwIgaJpZM4JoV-x
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar 1apweb 1apweb - test_item - 20 Aug 2016 - Tested successfully
avatar 1apweb
1apweb - comment - 20 Aug 2016

I have tested this item successfully on 66826b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11665.

avatar vales vales - test_item - 21 Aug 2016 - Tested successfully
avatar vales
vales - comment - 21 Aug 2016

I have tested this item successfully on 66826b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11665.

avatar zero-24 zero-24 - change - 21 Aug 2016
Status Pending Needs Review
avatar zero-24
zero-24 - comment - 21 Aug 2016

Moving to needs review so a maintainer can take that final decision. Thanka


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11665.

avatar stellainformatica stellainformatica - test_item - 22 Aug 2016 - Tested successfully
avatar stellainformatica
stellainformatica - comment - 22 Aug 2016

I have tested this item successfully on 66826b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11665.

avatar brianteeman
brianteeman - comment - 22 Aug 2016

This really cant be merged. We will be inundated with users screaming that
those two words just appeared on their web site hen they upgraded joomla
and demanding to know how to remove them

On 22 August 2016 at 17:44, ste notifications@github.com wrote:

I have tested this item successfully on 66826b8

66826b8

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11665
https://issues.joomla.org/tracker/joomla-cms/11665.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11665 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8SEWJ9tvR6s7uLAmsMprug7Rx-Zyks5qidHygaJpZM4JoV-x
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar stellainformatica
stellainformatica - comment - 22 Aug 2016

Very simple to remove if not needed indeed, just a language override.
In my opinion that title make more clear for the visitors why there are those links, for us it is quite logical, for the visitors not.

avatar brianteeman
brianteeman - comment - 22 Aug 2016

Are you offering to remove it from everyones web site that complains?

If you need it so much then create your own override.

On 22 August 2016 at 18:04, ste notifications@github.com wrote:

Very simple to remove if not needed indeed, just a language override.
In my opinion that title make more clear for the visitors why there are
those links, for us it is quite logical, for the visitors not.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11665 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ewa2AmK3YU0sKqU1LLME9Sys1A6ks5qidajgaJpZM4JoV-x
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar rdeutz
rdeutz - comment - 22 Aug 2016

I can understand both position but I will close this one for two reasons:

  • We have this for years and this is the first time someone noticed it as far as I know
  • Anyone can make an override
avatar rdeutz rdeutz - change - 22 Aug 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-08-22 20:17:06
Closed_By rdeutz
avatar rdeutz rdeutz - close - 22 Aug 2016
avatar vales
vales - comment - 23 Aug 2016

Motivations illogical and inconsistent. For two reasons.
1) there is a problem, but as it is the first time that someone finds it is not a problem. It is not proper motivation.
2) In fact, all are not able to make the template override.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11665.

Add a Comment

Login with GitHub to post a comment