[#11627] - Fix performance retrieving menu items in menus helper, e.g. when creating "Select page" filter in modules manager
- Fixed in Code Base
- 22 Aug 2016
- Medium
- Build: staging
- # 11627
- Diff
- ggppdk:patch-23
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10997
Fixes performance of creating" Select Page" filter (= menu item filter) in modules manager
Summary of Changes
Removed unused left join, joining menu items table with itself for no reason
No reason because
1. Join is LEFT
2. The results of the join are not used anywhere
- neither in SELECT clause nor WHERE clause and not in any other clause
- There is no PHP code that adds some usage of it under some condition
There is already another (different) self-join for the table on the lft/rgt, similar to the one removed when we limit to a specific parent parent
Testing Instructions
Visit module manager and open search filters, the "Select page" filter should be same as before, and behave as before
Documentation Changes Required
none
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
@prathumwan please mark as tested with success in https://issues.joomla.org/tracker/joomla-cms/11627?nocache
Login with github as mark as tested with success
I have tested this item
search filter for page works, performance is back
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.
also, since you have big set of menu items
besides this PR, also please see PR #11628 that
- fixes performance of menu item FORM
(fixes performance creating menuparent form element, (edit an item that belongs to a large menu)
Go to your largest menu and edit an item there:
then edit it with applying this patch: #11628 , and reply there and not here
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.
This PR patches the menus helper method: MenusHelper::getMenuLinks()
- so the performance is fixed in all places that use it
That is wherever a menu item select drop is created e.g. "search filter" "select page" in modules manager
and also edit forms that have assignments to menu items
- template edit form
- module edit form
administrator\components\com_modules\views\module\tmpl\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
administrator\components\com_templates\views\style\tmpl\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
administrator\templates\hathor\html\com_modules\module\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
administrator\templates\hathor\html\com_templates\style\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
libraries\cms\form\field\menuitem.php(160): $items = MenusHelper::getMenuLinks($menuType, 0, 0, $this->published, $this->language);
ok so with a small menu (15 menu items) we can still notice the changes:
Before patch
After patch
Note: Code i used for test:
!JDEBUG ?: JProfiler::getInstance('Application')->mark('- start query');
$links = $db->loadObjectList();
!JDEBUG ?: JProfiler::getInstance('Application')->mark('- end query');
I have tested this item
as comment above
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.
can we have RTC here?
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-22 19:51:01 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
tested successful, speed is back.