[#11611] - Some missing language text keys
- Fixed in Code Base
- 6 Sep 2016
- Medium
- Build: staging
- # 11611
- Diff
- brianteeman:missingstrings-redo
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10798
Summary of Changes
Added few strings but mainly it was correcting errors to make sure the correct string is bing used
joomla-cms-bot
- | Category | ⇒ | Tags Administration Components Language & Strings Templates (admin) Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
COM_CONTACT_SESSION_INVALID
This is inside a function "Method to submit the contact form and send an email" so I dont think it is correct to make that change
Many JLIB_ strings are used in specific extension methods. But nevermind
JLIB_ strings belong in the library translation files but can be used by extensions
extension strings belong in the extension language file and should only be used by that extension.
I have made the requested changed for
JLIB_STEMMER_INVALID_STEMMER
JLIB_CMS_WARNING_PROVIDE_VALID_NAME
Still not sure I understand the comments about COM_CONTACT_SESSION_INVALID should i move it to the JLIB_ or not?
I suggested you change that constant to a JLIB_ one and create the string in lib.joomla.ini
OK thats done - please test and then we can finish with this one
@wilsonge @infograf768 all the changes you wanted have been done - please test so we can get it merged and give translators as much time as possible
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 14:19:55 |
| Closed_By | ⇒ | wilsonge |
Thanks
Suggestion:
Change
COM_CONTACT_SESSION_INVALID="Invalid session cookie. Please check that you have cookies enabled in your web browser."
to a JLIB_ENVIRONMENT_SESSION_INVALID string as It could be used in the future in other extensions than contacts.
It would be placed just after
JLIB_ENVIRONMENT_SESSION_EXPIRED="Your session has expired. Please log in again."