Feeling Lucky
?
[#11610] - Obviously, this should be an array.
- Fixed in Code Base
- 15 Aug 2016
- Medium
- Build: staging
- # 11610
- Diff
- okonomiyaki3000:use-array-not-null
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
A variable was initialized as null which should only ever be an array.
It could cause problems when using a proxy and the stream transport because the variable might end up being passed to implode which is expecting an array.
Testing Instructions
In order to test this, you must have a proxy configured and you must use the stream transport which means disabling php's curl extension. I would suggest approving this based on code review instead since it's very simple and obvious.
Documentation Changes Required
I'm sure none.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
jeckodevelopment
- comment
- 15 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11610.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 15 Aug 2016
RTC Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11610.
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-15 10:07:12 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 0895ff6
code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11610.