Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11595] - [com_installer] Translate the extension name if possible

? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
14 Aug 2016

Pull Request for Issue #11567

Summary of Changes

Allow all kind of extensions to have translatable names

Testing Instructions

  • go to com_installer -> manage -> manage
  • select the type Library
  • see all items are translated (no language string)
  • go to the database and edit the entry for the Joomla Lib
  • set the name (collum params) to LIB_JOOMLA_XML_DESCRIPTION

{"name":"LIB_JOOMLA_XML_DESCRIPTION","type":"library","creationDate":"2008","author":"Joomla! Project","copyright":"Copyright (C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"https:\/\/www.joomla.org","version":"13.1","description":"LIB_JOOMLA_XML_DESCRIPTION","group":"","filename":"joomla"}

  • go to com_installer -> manage -> manage again
  • see it is not translated
  • apply this PR
  • see it is translated.

Documentation Changes Required

Nothing as this is the same as all other extensions.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Category ⇒ Administration Components
avatar zero-24 zero-24 - open - 14 Aug 2016
avatar zero-24 zero-24 - change - 14 Aug 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ?
avatar brianteeman brianteeman - test_item - 14 Aug 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Aug 2016

I have tested this item ✅ successfully on 44f1ae2

Followed test instructions - all good

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

avatar jeckodevelopment jeckodevelopment - test_item - 14 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2016

I have tested this item ✅ successfully on 44f1ae2

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

avatar zero-24
zero-24 - comment - 14 Aug 2016

@mbabker do you remember a reason for this conditional in the first place?

avatar mbabker
mbabker - comment - 14 Aug 2016

879de61

avatar zero-24
zero-24 - comment - 14 Aug 2016

Thanks. If that gots accepted i can move the names to the language files.

avatar brianteeman
brianteeman - comment - 14 Aug 2016

Setting RTC as we have two good tests. The count was just reset by the merge update

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

avatar brianteeman brianteeman - change - 14 Aug 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 14 Aug 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ?
avatar truptikagathara truptikagathara - test_item - 15 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 15 Aug 2016

I have tested this item ✅ successfully on 19e8832

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

avatar wilsonge wilsonge - close - 15 Aug 2016
avatar wilsonge wilsonge - merge - 15 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Aug 2016
avatar wilsonge wilsonge - change - 15 Aug 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-15 22:43:32
Closed_By ⇒ wilsonge
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2016
Labels Removed: ?
avatar zero-24
zero-24 - comment - 15 Aug 2016

Thanks. If that gots accepted i can move the names to the language files.

Done #11626

Add a Comment

Login with GitHub to post a comment