? Success

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
12 Aug 2016

Summary of Changes

A combination of two PRs #7368 and the commit for #5731 broke the ability to have visible ordering fields. This PR will fix the problem.

Testinstructions

  • Install a fof component with visible ordering fields (I have used admin-tools-pro, URL-Redirection) add some items and try to order with drag/drop and with changing the number in the field. This should fail.

  • Apply patch

  • Try it again and it should now work.

  • Test also ordering in the article manager and category manager

avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2016
Category JavaScript
avatar rdeutz rdeutz - open - 12 Aug 2016
avatar rdeutz rdeutz - change - 12 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 12 Aug 2016

Original fix was here #11571 this is a redo with testing instructions and without swearing.

avatar ggppdk
ggppdk - comment - 12 Aug 2016

To test

  • with making the ordering inputs visible (and thus editable too)

Joomla backend articles manager,
featured manager,
and category manager

  • Edit "styles" of isis template add file css/custom.css with:
.text-area-order, .sortable-handler + input {
  display: inline !important;
  width: 40px; text-align: right;
}
  1. In e.g. feature manager make hard refresh to get new JS loaded and sort by the ordering the column
  2. E.g. i have 10 records, manually (typing) reverse the last 4 items e.g. 7 - 8 - 9 - 10 to 10 - 9 - 8 - 7
  3. Drag and drop some of the records at the top, this will trigger an AJAX save too, like you clicked a save button, thus your manual ordering will get saved too
  4. DO a CTRL-F5 or similar refresh

Also if you want to add save button to the header of the column of e.g. featured manager
After:

<?php echo JHtml::_('searchtools.sort', '', 'fp.ordering', $listDirn ...

Add:

<?php echo JHTML::_('grid.order', $this->items, 'filesave.png', 'featured.saveorder' ); ?>
avatar ggppdk ggppdk - test_item - 12 Aug 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 12 Aug 2016

I have tested this item successfully on 40795cc

Tested

  • articles manager
  • featured mananager
  • category manager

drag and drop works

also about manual editing ordering numbers, after you edit some of them and:

  • either drag and drop some other row (to trigger save)
  • or if you have a save button visible and you click

then the ordering is saved good in this case too


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11572.

avatar ggppdk
ggppdk - comment - 12 Aug 2016

Also i forgot to mention

  • removing the CSS that i used above to make the fields visible (thus default Joomla styling to have them hidden)

then re-ordering works in this case too for the 3 managers, and also tested menu manager

avatar brianteeman brianteeman - test_item - 12 Aug 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Aug 2016

I have tested this item successfully on 40795cc

tested with admintools


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11572.

avatar wilsonge
wilsonge - comment - 13 Aug 2016

2 good tests. Merging

avatar wilsonge wilsonge - change - 13 Aug 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-13 09:56:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Aug 2016
avatar wilsonge wilsonge - merge - 13 Aug 2016
avatar truptikagathara truptikagathara - test_item - 13 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 13 Aug 2016

I have tested this item successfully on 40795cc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11572.

Add a Comment

Login with GitHub to post a comment