[#11503] - [com_contact] Make ACL core.edit.own work (PR for 11466)
- Fixed in Code Base
- 15 Aug 2016
- Medium
- Build: staging
- # 11503
- Diff
- andrepereiradasilva:acl-contact
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11466 (com_contact part).
Summary of Changes
The ACL core.edit.own is not working in com_contact.
This PR makes it work.
Testing Instructions
- Use latest staging
- Besides the Super User, create a user "test" added to "Administrator" group
- Go to com_contact Options, Permissions tab and diable "Edit" for "Administrator" group
- Now create a new contact with the "test" user (use another browser or a private window)
- Try to edit that item. You can't edit our own. Bug
- Now do the same test but with a contact category Permission. You can't edit our own. Bug
- Apply patch, repeat step 5. and 6. and now you can edit our own items.
- Code review
Also use the two users to do a general test with the com_contact edit permissions to confirm all is fine.
Documentation Changes Required
None.
Notes
This problem was discovered in GsoC 2016 Multilingual project.
This is very similiar with #11502.
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Note: The PR works great.
One issue, not related to this PR:
If the user is denied access to com_users Access Administration Interface (Typical for the default Manager group) then he can't assign a user to the Contact.
Needs some thought imho.
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.
I have tested this item
Changed my testing as we have a NOtice
[07-Aug-2016 07:10:36 UTC] PHP Notice: Undefined variable: record in ROOT/administrator/components/com_contact/controllers/contact.php on line 82
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.
sorry guys. corrected that. please test.
no more notice after last update
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.
I have tested this item
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I'm just going to hold on this until i can test some stuff ;)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-15 12:42:15 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Oh didn't realise we'd merged the other two. Merging this then. We can go back
I have tested this item✅ successfully on 3282bfd
:1:
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.