[#11502] - [com_newsfeeds] Make ACL core.edit.own work (PR for 11466)
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- # 11502
- Diff
- andrepereiradasilva:acl-newsfeed
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11466 (com_newsfeeds part).
Summary of Changes
The ACL core.edit.own is not working in newsfeeds.
This PR makes it work.
Testing Instructions
- Use latest staging
- Besides the Super User, create a user "test" added to "Administrator" group
- Go to com_newsfeeds Options, Permissions tab and diable "Edit" for "Administrator" group
- Now create a new newsfeed with the "test" user (use another browser or a private window)
- Try to edit that item. You can't edit our own. Bug
- Now do the same test but with a newsfeed category Permission. You can't edit our own. Bug
- Apply patch, repeat step 5. and 6. and now you can edit our own items.
- Code review
Also use the two users to do a general test with the com_newsfeeds edit permissions to confirm all is fine.
Documentation Changes Required
None.
Notes
This problem was discovered in GsoC 2016 Multilingual project.
This is very similiar with #11503.
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502.
I have tested this item
Changed my testing as we get a Notice (same as for contacts):
[07-Aug-2016 07:12:14 UTC] PHP Notice: Undefined variable: record in ROOT/administrator/components/com_newsfeeds/controllers/newsfeed.php on line 83
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502.
Yes variable name is $item not $record
sorry guys. corrected that. please test.
no more notice after the last update
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 16:20:22 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have not tested this, but it looks good on code review