Can you fix the code style issues please

FOUND 2 ERROR(S) AFFECTING 2 LINE(S)

330 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if (...)
| | ...{...}\n...else\n"
334 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if (...)

| | ...{...}\n...else\n"

hmm, there are cs errors indeed, but Travis gets that weird.

Looks it is just a matter of moving the { to next line and afew others, see below :)

updated, now it's correct?

Now it has passed the unit tests and needs some real humans to test it

ok, thanks

Can you provide some test instructions please. I tried a few things but didnt see any changes

well, I check it and found that this fix work only for JFormFieldEditor class (when used form.xml). But it doesnt work for "JEditor" class. So need another fix also.

Ups, I was wrong, it works fine too.

Use this code in some "view"

        $editorType = JFactory::getConfig()->get('editor');
        $editor = JEditor::getInstance($editorType);
        $editor->initialise();
        echo $editor->display('content_text', 'some text here', '400', '150', '60', '20'); // width: 400, height: 150

I have tested this item ? unsuccessfully on 8197497

Following your test instructions I found that the height did change but the width did not

@brianteeman

Following your test instructions I found that the height did change but the width did not

i confirm same behaviour

• but this is as good as we can get it without hacking tinymce.min.js ??

Here is some code from tinymce.min.js, you see that:
width is hard-coded to 100% and height is parametric ?? !!

... Press ALT-0 for help"),
style:{width:"100%",height:o,display:"block"}

Is it a bug, is it deliberate break of tinymce configuration ? i don't know, maybe i am missing something

To see the effect
e.g. at contact form has an editor field

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_contact/models/forms/contact.xml#L89-L96

add: height="217" width="854"

you will see that height works at editor
and both width and height work if you click "toggle editor"

we could add an div container external to the iframe and set width to it ??
but that will cause the width to behave as max-width, thus then you will not be able to enlarge the editor, any other ideas ?

And that code inside tinymce.min.js is 1 place,
similar hard-coding must be in more than 1 places ?

Guys, tinymce is rendered as a field, so being 100% from the script is ok, as we still have control over the parent div. in simple words the width should be applied in the jlayout at tinymce's parent div.

EDIT: just edit here:
https://github.com/joomla/joomla-cms/blob/staging/plugins/editors/tinymce/tinymce.php#L985

        $width  = ($textarea->width) ? ' style="width: ' . (int) $textarea->width . 'px"' : '';
        $editor = '<div class="editor"' . $width . '>';

This should fix that:

@dgt41 I think you are right. Will do that.

PS: this is not super solution, but I don't think that update of tinymce source is better.

PPS: how about of new editor? http://mindmup.github.io/bootstrap-wysiwyg/ looks nice.

@dgt41

very nice try, but have you seen my comment above ?

we could add an div container external to the iframe and set width to it ??
but that will cause the width to behave as max-width, thus then you will not be able to enlarge the editor, any other ideas ?

so what you suggest is similar to the above,
do we want it acting as a max-width , thus prevent enlarging ?

• i think we can only do it by adding width via JS that runs on-load-complete event of the editor, and adds width at 3 boxes that need it

http://archive.tinymce.com/wiki.php/API3:event.tinymce.Editor.onPostRender
(which is for tinymce 3, what is the page for tinymce 4 ?)

We just need to find the 2-4 places that are resized when editor resize and add an initial width
like:
$width
$width-15

@ggppdk the editor CAN NOT be resized more than the parent div. This will patch also another bug #8886 read my comment there: #8886 (comment)

Yes exactly, we agree on it

that is why i said not to add it to at: <div class="editor" ...
it does not only act as max-width,

• the display also gets cropped if you try to enlarge it

@dgt41

so i do not mean the container external to the editor
i mean the containers inside the tinymce code that are created after the editor renders

I have made 2 PRs to your branch (undoing last commit and doing the following)

This code works
Replace:

        tinymce.init({
        ";

with:

        function tinymce_setInitialWidth_".$id."(editor)
        {
            jQuery('iframe#".$id."_ifr').closest('.editor').find('.mce-container.mce-panel')
                .first().css({ 'width': '".$width."' });
            jQuery('iframe#".$id."_ifr').css({ 'width': '100%' });
        }

        tinymce.init({
            init_instance_callback : tinymce_setInitialWidth_".$id.",
        ";

[EDIT]
works when using percentage too

@ggppdk tinyMCE is vanilla js, blending jQuery is wrong IMHO (I know I done it elsewhere and I need to undo those instances)

@ggppdk tinyMCE is vanilla js, blending jQuery is wrong IMHO (I know I done it elsewhere and I need to undo those instances)

yes and i was thinking of it !!, while i was adding it
and you are right about it
it is best to keep it indepedent of jQuery,

So i did a text search in the file and found jQuery being used already , so i said i will use it

• when you replace the other jQuery selectors, can you replace these selectors too ?

lets not make it worse than it is and not create NEW jquery dependent stuff

On 9 August 2016 at 11:18, Georgios Papadakis notifications@github.com
wrote:

@ggppdk https://github.com/ggppdk tinyMCE is vanilla js, blending
jQuery is wrong IMHO (I know I done it elsewhere and I need to undo those
instances)

yes and i was thinking of it !!, while i was adding it
and you are right about it
it is best to keep it indepedent of jQuery,

So i did a text search in the file and found jQuery being used already
, so i said i will use it

• when you replace the other jQuery selectors you will replace these selectors too ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11489 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Wl97ovOGoqiiINVDAv4D_yRVzM1ks5qeFQIgaJpZM4JeMwb
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

lets not make it worse than it is and not create NEW jquery dependent stuff

no problem, i will replace the selectors and methods with native JS

wow, I missed so much. Should I do something or my help no needed?

@adamasantares Please see adamasantares#1

@wojsmol umm, sorry, may be I'm inattentive, but...what is the difference? That lines looks same... no?

UPD: ok, I think I see now. You are changed spaces to tabs

@brianteeman I propose to merge the current realization.

If this Issue get no Response, it will be closed at 22th September 2018.

@franz-wohlkoenig sorry I have no time to continue with this issue...

@adamasantares thanks for your Work and Time.