No Code Attached Yet J3 Issue
avatar jeckodevelopment
jeckodevelopment
5 Aug 2016

Steps to reproduce the issue

If you try to update from 3.6.0 to 3.6.2 through the Joomla! Update Component it will prompt the Stable Update Package, instead of the "3.6.x to 3.6.2". Obviously Stable Update Package's size is about 10 MB and it could cause some issues with some hosting providers.

If you try to update from 3.6.1 to 3.6.2, again the Stable Update Package is shown instead of the "3.6.1 to 3.6.2" that would be only few kb.

Expected result

Update should check the version and choose the right package.

Actual result

Update Component choose the stable update package that is a large file.

Screenshots

360-362
361-362

Additional comments

Is this an intentional behaviour?

avatar jeckodevelopment jeckodevelopment - open - 5 Aug 2016
avatar brianteeman
brianteeman - comment - 5 Aug 2016

dont know but any hosting provider that has a problem with it is probably
going to have much bigger problems than the package

On 6 August 2016 at 00:37, Luca Marzo notifications@github.com wrote:

Steps to reproduce the issue

If you try to update from 3.6.0 to 3.6.2 through the Joomla! Update
Component it will prompt the Stable Update Package, instead of the "3.6.x
to 3.6.2". Obviously Stable Update Package's size is about 10 MB and it
could cause some issues with some hosting providers.

If you try to update from 3.6.1 to 3.6.2, again the Stable Update Package
is shown instead of the "3.6.1 to 3.6.2" that would be only few kb.
Expected result

Update should check the version and choose the right package.
Actual result

Update Component choose the stable update package that is a large file.
Screenshots

[image: 360-362]
https://cloud.githubusercontent.com/assets/733133/17453042/2e9e44a8-5b76-11e6-926b-20a72e56aad1.PNG
[image: 361-362]
https://cloud.githubusercontent.com/assets/733133/17453043/2ea01f1c-5b76-11e6-8a8f-c09a4a543ef9.PNG
Additional comments

Is this an intentional behaviour?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11488, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UNX19JGOCuNnoPDWdcYulLIuFk0ks5qc8kegaJpZM4JeI5N
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar jeckodevelopment
jeckodevelopment - comment - 5 Aug 2016

@brianteeman agree :D but 10 mb is a bit large as package

avatar jeckodevelopment jeckodevelopment - edited - 5 Aug 2016
avatar jeckodevelopment jeckodevelopment - change - 5 Aug 2016
Title
[Joomla! Update Component] Wrong update package
[Joomla! Update Component] Wrong update package?
avatar jeckodevelopment jeckodevelopment - change - 5 Aug 2016
Title
[Joomla! Update Component] Wrong update package
[Joomla! Update Component] Wrong update package?
Labels Added: ?
avatar zero-24
zero-24 - comment - 6 Aug 2016

You need the stable update package else the reinstall feature can't work correct.

avatar zero-24
zero-24 - comment - 6 Aug 2016

As the 3.6.x - 3.6.2 contains only the changed files between this releases ;)

avatar wilsonge
wilsonge - comment - 6 Aug 2016

Also @jeckodevelopment remember that going between minor releases (e.g. from 3.5.1 to 3.6.0) everyone get's the stable update package by design anyhow.

I need to talk to Nic about how the reinstall feature works with the right packages on his return from holiday because I agree this is far from ideal. But this will wait until then

avatar wilsonge wilsonge - change - 6 Aug 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-08-06 10:38:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Aug 2016
avatar wilsonge wilsonge - close - 6 Aug 2016
avatar jeckodevelopment
jeckodevelopment - comment - 6 Aug 2016

thank you!

avatar zero-24
zero-24 - comment - 6 Aug 2016

how the reinstall feature works

It is simple ?

If you are on the version joomla is checking (you version = 3.6.2 & update server version 3.6.2) we still get the update details (from the extension.xml) so it is the same package.

And for reinstall we need this package as it should contain all code expected the install folder!

There are two way arround:

  • Let it as it is
  • create a additional reinstall URL in the extension.xml which is used by the updater for reinstall.
avatar zero-24
zero-24 - comment - 6 Aug 2016
    <update>
        <name>Joomla! 3.6</name>
        <description>Joomla! 3.6 CMS</description>
        <element>joomla</element>
        <type>file</type>
        <version>3.6.2</version>
        <infourl title="Joomla!">https://www.joomla.org/announcements/release-news/5667-joomla-3-6-2-released.html</infourl>
        <downloads>
            <downloadurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip</downloadurl>
            <reinstallurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.2-Stable-Update_Package.zip</reinstallurl>
        </downloads>
        <tags>
            <tag>stable</tag>
        </tags>
        <maintainer>Joomla! PLT</maintainer>
        <maintainerurl>https://www.joomla.org</maintainerurl>
        <section>STS</section>
        <targetplatform name="joomla" version="3.6" />
        <php_minimum>5.3.10</php_minimum>
    </update>

This could be a example. Now we need the Updater check and use that URL.

avatar jeckodevelopment
jeckodevelopment - comment - 6 Aug 2016

I agree @zero-24 for the reinstall feature we need the "Stable-Update-Package", ok... but, if we have only to update, it could be useful to choose the correct package that is smaller.

avatar zero-24
zero-24 - comment - 6 Aug 2016

PR is: #11497

avatar jeckodevelopment
jeckodevelopment - comment - 7 Aug 2016

This issue had been already closed, but now we have a PR to test. Thank you @zero-24

avatar zero-24 zero-24 - change - 20 Nov 2016
The description was changed
Status Closed New
Closed_Date 2016-08-06 10:39:03
Closed_By wilsonge
avatar zero-24 zero-24 - reopen - 20 Nov 2016
avatar zero-24 zero-24 - reopen - 20 Nov 2016
avatar zero-24
zero-24 - comment - 20 Nov 2016

Re open here as the PR is broken/closed now :(

avatar brianteeman brianteeman - change - 21 Nov 2016
The description was changed
avatar brianteeman brianteeman - edited - 21 Nov 2016
avatar brianteeman brianteeman - change - 21 Nov 2016
Category com_joomlaupdate
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Apr 2017
Status New Needs Review
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar roland-d
roland-d - comment - 22 Jul 2018

@zero-24 Now that issue #18926 has been merged do you want to revisit this topic?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11488.

avatar zero-24
zero-24 - comment - 22 Jul 2018

What do you mean by revisit? The issue here can't be fixed by the changes merged. They are just fall backs in case of errors.

avatar roland-d
roland-d - comment - 22 Jul 2018

@zero-24 I thought that PR #11497 contained the fixes to allow patch installs. In issue #18926 Michael wrote:

Conceptually doing a "soft" reservation on the tag attributes and defining standardized values allows us to revisit PRs like #11497 and work on optimizing the packages served through the update component for the various update/install paths instead of always serving the largest of the packages we have (so the 3.8.1 to 3.8.2 update could receive the optimized 1.07 MB ZIP file instead of requiring the full 11.37 MB ZIP file, less bandwidth expense and a smaller number of files to process in the update cycle, everyone wins)

So I was under the impression your PR would allow doing this.

avatar zero-24
zero-24 - comment - 22 Jul 2018

After the PR was ignored and than broken because of merge conflicts I have closed it. The PR (from Michael) that got merged is just a fallback and does not support the feature requested here.

avatar roland-d
roland-d - comment - 22 Jul 2018

@zero-24 Ok, clear. Do you have any interest in picking up the PR again?

avatar zero-24
zero-24 - comment - 22 Jul 2018

No not at the moment. When you have time feel free to pick it up.

avatar roland-d
roland-d - comment - 22 Jul 2018

Was not interested in picking it up but we are getting students to do some testing the next two days. This may have been tested. Will leave this for whomever wants to pick it up.

avatar chnnst
chnnst - comment - 17 Feb 2021

can we close this?

avatar brianteeman
brianteeman - comment - 23 Aug 2022

Thank you for raising this issue.

Joomla 3 is now in security only mode with no further bug fixes or new features.

As this issue doesn't relate to Joomla 4 it will now been closed.

If we are mistaken and this does apply to Joomla 4 please open a new issue (and reference this one if you wish) with updated details for testing in Joomla 4.
cc @zero-24

avatar zero-24 zero-24 - change - 23 Aug 2022
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2022-08-23 10:17:11
Closed_By zero-24
Labels Added: No Code Attached Yet
Removed: ?
avatar zero-24 zero-24 - close - 23 Aug 2022
avatar zero-24
zero-24 - comment - 23 Aug 2022

Its an issue that can be picked up later but thats a more or less longstanding issue so I will agree that we are closing this here for now.

Add a Comment

Login with GitHub to post a comment