[#11478] - Remove show_tag_num_items
- Closed
- 25 Nov 2016
- Medium
- Build: staging
- Easy Test
- # 11478
- Diff
- brianteeman:tagcount
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
com_tags has an option that "Shows the number of items with a given tag."
Except there is no code anywhere to use that option which makes sense as we display the items with the tag and not the number items for each tag. That is something the tags-popular module does not the tags component ir tags menu item
This PR removes this useless option
joomla-cms-bot
- | Category | ⇒ | Tags Administration Components Front End Installation SQL Postgresql MS SQL Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
Yes that's correct but unaffected by this pr (I hope)
| Title |
|
||||||
| Labels | |||
| Easy | No | ⇒ | Yes |
| Labels | |||
I have tested this item
Tested successful - All appearances are gone.
But will it break B/C if anyone used it in own overrides ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11478.
But will it break B/C if anyone used it in own overrides ?
Yes and no. Yes in that there is no longer a value to check the next time the parameters for one of these sections are saved (it'll still persist in the database even though it's no longer in the XML file). No in that all the parameter code has a default value to use in case the parameter's value isn't set, so whatever the default in the PHP file is will be used in those cases.
@brianteeman there's a merge conflict in installation/sql/sqlazure/sample_testing.sql (and GitHub finally tells us this, yay for small miracles)
Tested succesfully, with MySQL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11478.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11478.
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11478.
I have tested this item succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11478.
@brianteeman can you please look at conflicts?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-25 11:00:00 |
| Closed_By | ⇒ | brianteeman |
For the display of the number items for each tag we may have this pr #10895 in addition to the tags-popular module