[#11477] - Remove unused paramater in Tags:Tagged Items
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11477
- Diff
- brianteeman:modulemax
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
There is a parameter in the menu item Tags:Tagged Items, item selection options called "maximum"
This shouldnt be there at all as there is no code to use the param. It looks like a siple copy paste error from another tag menu item
Summary of Changes
This simple PR removes the option
Even if a user had set a value here there is no b/c issue as there was no code that would ever use the value
joomla-cms-bot
- | Category | ⇒ | Tags Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
is the #11478 a superset of this PR ?
https://github.com/joomla/joomla-cms/pull/11478/files#diff-6dab3edb55404956be95a14631af9fc7L258
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11477.
@alikon I did them as seperate pr as they were wrong for different reasons and I wanted to keep them seperate in case I had missed some weird way they were being used.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11477.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 18:05:56 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 25f3cbe
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11477.