? ? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
3 Aug 2016

Summary of Changes

When JErrorPage::render() instantiates the JDocumentError instance for the error page, it doesn't inject any attributes into the object the same as if it were instantiated through another path (i.e. the install app's loadDocument method). This means the JDocumentError doesn't have the correct language or direction data within it if checking $this->language or $this->direction as done in HTML templates.

This PR will inject the same attributes into the JDocumentError instance as if it were instantiated another way and if the language data is available (it may be possible to hit the error page before the JLanguage singleton is instantiated) we'll add that to the attributes array.

Testing Instructions

Set your template to Beez3 for the frontend or Hathor on the backend; the other templates try to grab these attributes out of the JDocument instance in JFactory so it's harder to test against them. Trigger an error page somehow, preferably with another language active. Pre-patch, note the incorrect attributes in the <html> tag. Post-patch, it should be correct if JLanguage has been instantiated before the error page has been triggered.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Category Libraries
avatar mbabker mbabker - open - 3 Aug 2016
avatar mbabker mbabker - change - 3 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Category Libraries Libraries Unit Tests
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 15 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Aug 2016

I have tested this item successfully on 78499e2

works as described. tested with beez3


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11403.

avatar truptikagathara truptikagathara - test_item - 26 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 26 Aug 2016

I have tested this item successfully on 78499e2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11403.

avatar zero-24 zero-24 - change - 26 Aug 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 26 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11403.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 27 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-27 18:42:47
Closed_By rdeutz
avatar brianteeman
brianteeman - comment - 27 Aug 2016

Thanks

avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment