[#11402] - Use intro_image in newsfeed
- Fixed in Code Base
- 20 Aug 2016
- Medium
- Build: staging
- # 11402
- Diff
- brianteeman:newsfeed
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #8198 .
Summary of Changes
Publishing RSS feeds from Joomla doesn't include the intro_image field
Testing Instructions
Publish a news feed for a category and ensue that at least one article in the category uses the intro_text field
This code is provided by @nunoleite
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Thanks for adding this code.
I just wanted to add that this should be implemented in this file too:
/components/com_content/views/featured/view.feed.php
This will add the same to the rss newsfeed from a blog of featured articles.
Something like this:
$db->setQuery($query);
$row->fulltext = $db->loadResult();
//line commented by nunoleite
// $description = ($params->get('feed_summary', 0) ? $row->introtext . $row->fulltext : $row->introtext);
// code added by nunoleite, to add intro image to the newsfeeds
$description = '';
$obj = json_decode($row->images);
$introImage = ( isset( $obj->{'image_intro'} ) ) ? $obj->{'image_intro'} : '' ;
if (isset($introImage) && ($introImage != "")) {
$image = preg_match('/http/', $introImage)? $introImage : JURI::root().$introImage;
$description = '<p><img src="'.$image.'" /></p>';
}
$description .= ($params->get('feed_summary', 0) ? $row->introtext . $row->fulltext : $row->introtext);
// end of code added by nunoleite
$author = $row->created_by_alias ? $row->created_by_alias : $row->author;
// Load individual item creator class
I have this implemented on my sites and is working.
Thanks
Nuno Leite
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
I will update for the other views this afternoon
added the featured content feed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
@nunoleite can you test this please so we can get it merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
| Status | Pending | ⇒ | Ready to Commit |
RTC please
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Removing RTC - Fix needed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
| Labels |
Removed:
?
|
||
Pull requests to my branch are welcome. It's not my pr I just created it
with user submitted code
I made the changes to add the blank lines - can someone put the RTC back?
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
set RTC and milestone
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-20 11:47:44 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
ups you are right, I need to revert this
@brianteeman will you make a redo of the PR or should I?
@brianteeman thanks and sorry, I shouldn't do three things at ones :-)
I have tested this item✅ successfully on a26cd72
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11402.