User tests: Successful: Unsuccessful:
Menu edit form / Module assignment TAB
The /td is move down to include the HTML code of the modal
Review code to see that the /td move after the hidden modal HTML code
Category | ⇒ | Administration Components |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I have followed these steps but not able to reproduce this issue.
Error Reporting set to "Maximum" still not able to see any warning.
Joomla! Version : Joomla! 3.6.1-rc2 Release Candidate [ Noether ] 31-July-2016 16:51 GMT
I have tested this item
Thanks everybody
Please see here, there is HTML code AFTER (outside) a TD cell !, it is invalid HTML
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_menus/views/item/tmpl/edit_modules.php#L133-L134
Error Reporting set to "Maximum" still not able to see any warning.
You do not need to do this
This is not a PHP warning or notice, this PR is about invalid HTML
I have tested this item unsuccessfully on ...
Ok, thanks!, for testing, but what was not successful ?
Please everybody see below, this is invalid html:
<tr>
...
<td>
...
</td>
<div> this is a hidden div with modal code </div>
</tr>
Correct is:
<tr>
...
<td>
...
<div> this is a hidden div with modal code </div>
</td>
</tr>
I hope it is more clear now
Please view the source code of the HTML, to confirm the issue,
also here is the location again:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_menus/views/item/tmpl/edit_modules.php#L133-L134
I have tested this item
@ggppdk I agree about the invalid html issue, and some time after my last update on the hidden modal content, i discovered this error too, i found it was there this way since a long time...
Unfortunately, your proposed change fix html, but returns now a bug on saving the module modal... (just test with your change to open a modal, and then click on Save & Close
, and you will see what issue i mean)
I've tried the same change as yours (to have valid HTML) but unfortunately, this breaks the module modal...
(note: i have tried to by placing the Bootstrap modal div just after the /tr and before endforeach, code works, but again an invalid HTML rendering... (even if not visible for user))
Honnestly, i don't know yet how to fix it... :-|
At a glance this change looks right, however the PR needs to be synchronized to the current development branch.
is this PR ready for testing?
At a glance this change looks right, however the PR needs to be synchronized to the current development branch.
Also i have not fixed the JS that depends on this wrong nesting, since i have not spent any time for this PR, i will close it for now
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 04:42:13 |
Closed_By | ⇒ | ggppdk |
Category | Administration Components | ⇒ | Administration com_menus Components |
I have tested this issue, but able to reproduce this issue in Joomla Version Joomla! 3.6.1-rc2 Release Candidate [ Noether ] 31-July-2016 16:51 GMT
Will you please describe more about this issue?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11395.