I have tested this item ✅ successfully on a5a8140

it's good for me Thanks

I have tested this item ✅ successfully on a5a8140

Setting RTC as the tests are still good - the last commit was just to fix a doc block

@wilsonge your call on where/when this gets merged

@dgt41 did you check this one also? #11353

@andrepereiradasilva that was a long standing bug and I think that PR needs to be merged asap. Partly was solved by moving the script tag out of the inline text, but the regex was also a needed fix, IMHO

ok thanks

Thanks for fix DImitri

I have tested this item ✅ successfully on 4f53e47

I' tested successfully multiple emails within table elements.
That was working under 3.6.0, now broken while updating my test site to 3.6.1RC2. Please include this patch in 3.6.1.

I have tested this item ✅ successfully on 4f53e47

@dgt41
Do I understand correctly that this patch can be used for 3.6.1 to fix the issue? No dependencies at the moment?
(if I know what I do ;-) )

@wilsonge maybe we should ship that with 3.6.2 too?

Taking off RTC until we tested the last commit.

@Fedik done!

@dgt41 one missed ?

Joomla.addListener('DOMContentLoaded', init, document);
Joomla.addListener('readystatechange', init, document);
Joomla.addListener('load', init, window);

to

Joomla.addListener(document, 'DOMContentLoaded', init);
Joomla.addListener(document, 'readystatechange', init);
Joomla.addListener(window, 'load', init);

I have tested this item ? unsuccessfully on 8378656

Tested with Joomla 3.6.1 Updated yesterday. Now ALL Emails of the site show "This email address is being protected from spambots..." even if just one on page.

I have tested this item ? unsuccessfully on 8378656

On a 3.6.1 website, I applied the patch but emails are still not displayed, same message as before applying the patch "This email address is being protected from spambots. You need JavaScript enabled to view it."

@bertmert @Sandra97 you are right, I messed this up. It should be ok now

I have tested this item ? unsuccessfully on 5e1e386

I tested it again.
The good news: the message is not displayed anymore and if you have just a single email in your html code, it works fine
The bad news: if you have a more "complex" code for the email link, for example:
email
Email is displayed but the class is not applied on the frontend

For all emails, my source code becomes: email
(the class has disappeared).

Or is it me doing something wrong?

@Sandra97 what is the exact code that you are using (in the example I see only an email text, use ` before and after the code so I can see it)

@dgt41 , ouch, my code is hidden ;)
Here it is
<a href="mailto:toto@toto.com?subject=Subject" class="nameofmyclass">email</a>

Hmm, that's strange because I didn't touch the logic of the script, I just add it to the head instead of being next to the tag. Did that worked before? Maybe has to do with #11353 ?

It worked perfectly fine before the update to 3.6.1.

Note that I don't have any module integrated into the article.

I can of course find a (bad) way to make the class working again, by surrounding the email by a div containing the class, but I'm not a big fan of this solution for my website.

I have tested this item ✅ successfully on 5e1e386

Tested with Joomla 3.6.1 updated from 3.6.0 yesterday.
2 email links with simple structure like contact@example.org on 1 page.
Others with just 1 email link are fine, too

I have tested this item ✅ successfully on 5e1e386

I've re-tested with the same "multiple emails within table elements" the same way I did on Aug 1st.
Summary:
3.6 was ok
3.6RC2 broken.
3.6RC2 + patch was OK.
3.6.1 broken
3.6.1 + patch works again.
Thank you

Is this good to go for merging in 362 then?

@dgt41 For info, I applied also #11353 but not change. Display is still not ok for me (except of course if I turn off Email Cloaking)
With 3.6.0

With 3.6.1 and patch applied

I have tested this item ✅ successfully on 5e1e386

Confirmed broken on Joomla 3.6.1 Stable.

Applied PR #11378 using com_patchtester

Refreshed article, and see all the emails fine.

Tested in Beez and Protostar templates too. All fine.

The patch works fine when you have a simple email address, not when you have a CSS class for the link. But it can be a template issue?

@Sandra97 - keep that comment in the right PR/Issue :) #11353

Sorry, you're right.

@Sandra97 @PhilETaylor can you retest?

I'll retest it after dinner

I updated from 3.6.1 to 3.6.2 the website on which I had the issue. Everything is now ok, my class is here, all email addresses are displayed as expected.

Thank you very much!!!

Hm the code is not in 3.6.2, you have to use patch tester ?

So I'll reinstall a 3.6.1 backup to test it, I'll do it tomorrow morning.

No need to go back to 3.6.1, just apply the this patch and check the emails

I tried to apply it after updating to 3.6.2 but it doesn't succeed to apply it. Maybe just an operator error, I'm a bit tired ;)

@dgt41
I can confirm that the issue is solved with Joomla 3.6.2.
I updated from Joomla 3.6.1 to 3.6.2. Afterwards I copied the whole Full Package 3.6.2 via FTP in my webspace to be sure. All emails are cloaked correctly without any patch.

@bertmert that should be true as @wilsonge reverted part of the PR that moved the script to the head of the document. Check https://github.com/joomla/joomla-cms/pull/11378/files#diff-a5e4a8ab7a94472482aa9109f381223fL102
So this PR (as is with commit a250539) is a new attempt to add the scripts into the head but without breaking the extra markup that might exist before or after the email. In short if you want to test this one you need to apply the patch and test different scenarios for email addresses

I suggest this is not merged until we have a complete Unit Test suite for the the Email Cloaking plugin, which I have started in #11462 - I'll work on that more today as its very far from finished, and just a base to work from at the moment.

@PhilETaylor I will spent some time this weekend to see if another approach is a better fit (I hate all those regexes)

At various points in time on various pull requests @infograf768 has had a
big long list of email links to test

On 5 August 2016 at 09:36, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@PhilETaylor https://github.com/PhilETaylor I will spent some time this
weekend to see if another approach is a better fit (I hate all those
regexes)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11378 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XVV0m7E8eC6kTgSY2RVeocDSN-8ks5qcvYKgaJpZM4JZU_d
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I have tested this item ? unsuccessfully on a250539

When using Patchtester to apply the patch on my 3.6.2 site test, I had the message it was not possible to apply it due to a conflict with email.php file.
So I applied it manually (once by copy/paste the whole content of the 4 files and once by adding/removing the changes only).

My original HTML code is:
<a href="mailto:toto@toto.com?subject=Mysubject" class="myclass" >email</a>

After applying the patch, it becomes:
<span id="cloakafa11adb16abf1bf4404ded6e1b901a3"><a href="mailto:toto@toto.com?subject=Mysubject class=&quot;myclass&quot;">email</a></span>

So the HTML is "corrupted" so it does not work as expected.

see, if we had had unit tests, then this would be oh so much easier cough cough...

So this PR (as is with commit a250539) is a new attempt to add the scripts into the head but without breaking the extra markup that might exist before or after the email. In short if you want to test this one you need to apply the patch and test different scenarios for email addresses.

@dgt41
Maybe it would be good to change the title and the testing instructions of this PR then?

Thanks for testing here, I am gonna close this one now until we have proper unit tests. Once those will be available I will open a new one