[#11355] - [com_menus] New menu item. Force client in menu item parent to not show admin menus
- Fixed in Code Base
- 12 Aug 2016
- Medium
- Build: staging
- # 11355
- Diff
- andrepereiradasilva:menu-client
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
Another joomla cms bug was discovered in joomla gsoc multilangue project.
When creating a new menu item without menu type selected the parent id select box shows all site AND admin menus!
This PR intends to solves that.
Testing Instructions
- Use latest staging
- Logout
- Login in Admin and go directy to Menus -> All Menu Items
- Click New
- Check the parent menu selector. you will see something like this
- Apply patch
- Do the same tests, check all is fine
- Test creating/editing menu items to make sure nothing is breaked
- Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I thought I couldnt replicate this but it only happens if you do step 3
On 29 July 2016 at 17:33, andrepereiradasilva notifications@github.com
wrote:
Pull Request for New Issue.
Summary of ChangesAnother byg was discovered in joomla gsoc multilangue project.
When creating a new menu item without menu type selected the parent id
select box shows all site AND admin menus!
Thsi PR solves that.
Testing Instructions
- Use latest staging
- Logout
- Login in Admin and go directy to Menus -> All Menu Items
- Click New
- Check the parent menu selector. you will see something like this [image: image] https://cloud.githubusercontent.com/assets/9630530/17255703/3bc8942c-55b2-11e6-8b59-88fa2176bc89.png
- Apply patch
- Do the same tests, check all is fine
- Test creating/editing menu items to make sure nothing is breaked
- Code review
You can view, comment on, or merge this pull request online at:
#11355
Commit Summary
- force client in menu item parent
File Changes
- M administrator/components/com_menus/models/fields/menuparent.php https://github.com/joomla/joomla-cms/pull/11355/files#diff-0 (9)
- M administrator/components/com_menus/models/forms/item.xml https://github.com/joomla/joomla-cms/pull/11355/files#diff-1 (1)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/11355.patch
- https://github.com/joomla/joomla-cms/pull/11355.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11355, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cPXsSDXB-c_fXNnyWzB7jR8sM3Lks5qaitngaJpZM4JYXGu
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
yeah, it happens when you don't have any menu type in user state. that's why i say in test instructions to logout.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.
3.6.2 milestone?
ok it's 3.6.3 sorry
unable to mark successfull test on issues.joomla.org
@alikon I can do it for you if needed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.
thanks brian
there is no need as it is already RTC
p.s.
grrr i'm still experiencing "strange" issues with issues.joomla.org
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-12 15:08:56 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on
This works fine.
The issue is a side effect of the new All menu items PR as, before that, the Menu field was always filled and we got the right possible parents.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.