How to test this? Tried a few different things -

1. apply patch to 3.6 and update to rc1
2. update with com_joomlaupdate to a zip from your branch
3. apply patch to 3.6 and update with com_joomlaupdate to a zip from your branch

They all show the same Notice

On 29 July 2016 at 09:35, Robert Deutz notifications@github.com wrote:

fix for #11335 #11335

JPATH_ROOT is 100% set because it is used to include the script and run it

You can view, comment on, or merge this pull request online at:

#11347
Commit Summary

• removed unset path constants
• typo in path

File Changes

• M administrator/components/com_admin/script.php https://github.com/joomla/joomla-cms/pull/11347/files#diff-0 (16)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/11347.patch
• https://github.com/joomla/joomla-cms/pull/11347.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11347, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YzhjDUnP0Ff6lpAWy3oJ3z5CELaks5qabtSgaJpZM4JX_Bp
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

let me re-build the packages

I took a clean 3.6 site and updated it using the manual upload in com_joomlaupdate and your build that you sent me and it upgraded without error

I have tested this item ✅ successfully on 6796a7b

if someone likes to test, I have a patched RC1 package to test, just ping me

@rdeutz Ping ;-) Can reproduce the PHP notices with error reporting set to development updating a 3.6.0 with an unpatched RC1 and so could test if they have gone with your patched RC1 on another 3.6.0 with identical infrastructure and data. How can I get your patched RC?

3.6.1.rc1a.zip

Thought can send you a link, but github is hiding your email, uploaded it here

last comment was for @richard67 :-)

I have tested this item ✅ successfully on 6796a7b

Fixes the PHP notices described in #11335 .

There were other issues related to the patched RC1 was packed when I tested (some schema updates were broken links and not files), and so the database fix page has shown PHP problems, but this is not related to this PR.

RTC