[#11325] - Argument must be array, null was passed instead.
- Fixed in Code Base
- 28 Jul 2016
- Medium
- Build: staging
- # 11325
- Diff
- okonomiyaki3000:argument-must-be-array
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Third argument passed to JClientFtp::getInstance must be an array. Null was passed instead, results in catchable fatal error (only if FTP is used).
Testing Instructions
I recommend that this be accepted on the basis of code review alone as the problem and solution are quite obvious and testing this function is not trivial.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-28 06:59:11 |
| Closed_By | ⇒ | roland-d |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-07-28 06:59:11 | ⇒ | |
| Closed_By | roland-d | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-28 06:59:30 |
| Closed_By | ⇒ | roland-d |
It seems so.
Untested pull requests ;(
On 4 August 2016 at 12:17, Elijah Madden notifications@github.com wrote:
It seems so.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11325 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8aoWgxtlpR1lvTub8tqOKG_WmT3Jks5qccpWgaJpZM4JW46s
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
The mode FTP Update was broken befor.
0 Argument 3 passed to JClientFtp::getInstance() must be of the type array, null given, called in /srv/www/vhosts/mysite.ch/httpdocs/libraries/joomla/filesystem/file.php on line 488
please double read the error message.
This here give a array and not a null.
yes, these changes are not the cause of the issue,
they fix it, and J3.6.0 does not contain these fixes
see my comment here:
#11432 (comment)
and also does the error appear only in PHP7 ?
The change is right, the parameter is typehinted to array so it's correctly fixing an issue.
It's been a while since I looked but I think PHP 7 is a little more strict on typehints than PHP 5 was so the fact it was passing a null to a typehinted array wasn't a big deal. We've fixed some signatures in the Framework code that had something like array $options = null which raised errors too.
Merged based on code review.