? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
20 Jul 2016

Pull Request for "Although connection can be omitted, it is not recommended".

Summary of Changes

The pg_query() manual states "Note: Although connection can be omitted, it is not recommended, since it can be the cause of hard to find bugs in scripts." looks like HHVM is more strict about expecting the connection parameter.

This also solves a notice in HHVM testing pg_query() expects exactly 2 parameters, 1 given

Testing Instructions

Test by checking for normal function under PostgreSQL or I recommend by code review.

avatar photodude photodude - open - 20 Jul 2016
avatar photodude photodude - change - 20 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 21 Jul 2016
Category Libraries Libraries Postgresql
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar wilsonge wilsonge - reference | 1d55558 - 21 Jul 16
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar wilsonge wilsonge - change - 21 Jul 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-21 12:33:20
Closed_By wilsonge
avatar wilsonge wilsonge - change - 21 Jul 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Category Libraries Postgresql Libraries

Add a Comment

Login with GitHub to post a comment