? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
20 Jul 2016

Summary of Changes

In backend edit item (article, contact, newsfeed, menu item, etc) layout we can call the page with &tpml=component, but when we submit the form (ex: through javascript in a parent iframe) we go back to the non component (default) template with side bar.

This PR correct that.

Testing Instructions

Code review.

More info

This problem was discovered in GsoC 2016 multilingual project.

@infograf768 @alikon @jreys please test.

avatar andrepereiradasilva andrepereiradasilva - open - 20 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - change - 20 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 20 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 20 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 20 Jul 2016
The description was changed
cef24a1 20 Jul 2016 avatar andrepereiradasilva cs
ba8a2fb 20 Jul 2016 avatar andrepereiradasilva cs
54883e5 20 Jul 2016 avatar andrepereiradasilva cs
872c309 20 Jul 2016 avatar andrepereiradasilva cs
avatar alikon alikon - test_item - 20 Jul 2016 - Tested successfully
avatar alikon
alikon - comment - 20 Jul 2016

I have tested this item successfully on 872c309


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar jreys jreys - test_item - 20 Jul 2016 - Tested successfully
avatar jreys
jreys - comment - 20 Jul 2016

I have tested this item successfully on 872c309


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar JoomliC
JoomliC - comment - 20 Jul 2016

Well found! ?
Maybe to be done in com_modules module edit, where i did the same $tmpl Variable set?

avatar JoomliC JoomliC - test_item - 20 Jul 2016 - Tested successfully
avatar JoomliC
JoomliC - comment - 20 Jul 2016

I have tested this item successfully on 872c309


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar infograf768 infograf768 - test_item - 21 Jul 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 21 Jul 2016

I have tested this item successfully on 872c309

Totally B/C and solves the GSOC issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar infograf768 infograf768 - change - 21 Jul 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 21 Jul 2016

RTC. Thanks!

@wilsonge

Please merge in 3.6.1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Category Administration Components
avatar infograf768 infograf768 - change - 21 Jul 2016
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 21 Jul 2016

Back to pending. Needs a small correction.

missing

$input = JFactory::getApplication()->input; for menus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Removed: ?
avatar infograf768
infograf768 - comment - 21 Jul 2016

@andrepereiradasilva
Please correct

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Jul 2016

corrected emnu issue and added to com_modules. Please retest

avatar infograf768 infograf768 - test_item - 21 Jul 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 21 Jul 2016

I have tested this item successfully on 111fbea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar alikon alikon - test_item - 21 Jul 2016 - Tested successfully
avatar alikon
alikon - comment - 21 Jul 2016

I have tested this item successfully on 111fbea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar infograf768 infograf768 - change - 21 Jul 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 21 Jul 2016

RTC now for good. :)

@wilsonge

Please merge.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 21 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-21 11:16:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 21 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment