[#11105] - Empty article list in mod_articles_category module when ordered by fp.ordering
- Fixed in Code Base
- 26 Jul 2016
- Medium
- Build: staging
- # 11105
- Diff
- bertmert:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11100 .
Summary of Changes
@csthomas
Fix for changes made in #9161
Force left JOIN over table #__content_frontpage whenever list.ordering is set to Featured Articles Order
Testing Instructions
- Install Joomla 3.6.0 with testing datas.
- Create new module of type
Articles Category - Position
banner.On all pages. - Set
Filtering Options > Category > All Categories. - Set
Filtering Options > Featured Articles > Whatever you want. Set
Ordering Options > Featured Articles OrderGo to frontend ==> empty list but PHP warnings
Warning: Invalid argument supplied for foreach() in /components/com_content/models/articles.php on line 578
Warning: Invalid argument supplied for foreach() in /modules/mod_articles_category/helper.php on line 235
Apply patch.
Try again and test other views that use same model, too, pleasepleaseplease.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Modules |
| Rel_Number | 0 | ⇒ | 1100 |
| Relation Type | ⇒ | Pull Request for |
I admit I missed mentioned case in #9161.
Ordering by fp.ordering is primary ordering (only one) then may be better is to use INNER JOIN instead LEFT JOIN.
Notice that only featured articles will be returned.
I suggest to add below lines (before line 235) instead use LEFT JOIN:
elseif ($this->getState('list.ordering') == 'fp.ordering')
{
$query->join('INNER', '#__content_frontpage AS fp ON fp.content_id = a.id');
}What do you think?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11105.
How can I take over this PR. Should I create a new one? I'm new in github tools.
How can I take over this PR.
You could create a new one, inform us and I will close mine.
OR:
Log in.
Click "Files changed" tab above.
Edit my commit (github.com/bertmert/joomla-cms/edit/patch-7/.....) via pencil button
and send it as PR to my branch. Then I can merge it to this PR.
I withdraw my suggestion.
For now your PR is OK.
After 2 tests it should go to RTC.
For later filter.frontpage should be replaced by filter.featured and etc.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11105.
@csthomas
In my opinion you can't use INNER JOIN, because this is only an ordering option, so it shouldn't exclude not featured articles, but put them after all featured articles on the list.
There is dedicated filter to display only featured articles and I can agree that it's better to use INNER JOIN, but only if this filter is set to display only featured articles.
Yes I have seen it too, then I withdrew/back my suggestion.
There is place for more work for other PR,
ex sometimes there is 'filter.frontpage' but other time 'filter.featured'
Shouldn't this one get a RTC ? Would be nice to see it in 3.6.1 because it's fixing a bug.
@brianteeman RTC for 3.6.1 ?
@brianteeman
Sorry for pushing! Is there a reason why no RTC? Even if there were some discussions all agreed in the end that this PR (bug-fix) is OK.
| Status | Pending | ⇒ | Ready to Commit |
RTC
3.6.1 ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11105.
| Labels |
Added:
?
|
||
| Category | Modules | ⇒ | Front End Components |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-26 09:42:17 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Merged. Thanks guys
I have tested this item✅ successfully on 293e5da
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11105.