User tests: Successful: Unsuccessful:
Pull Request for Issue #11091 .
Hopefully this is the last time I do this
Follow the instructions from the issue above:
For the sake of using SqueezeBox (MooTools based) instead of the Bootstrap Modal, change the Administrator template to Hathor. It's damn ugly, I know :)
Make sure you're using TinyMCE as your Editor.
Go to Content > Articles > Add New Article.
In the Publishing area, click on the "User" icon so you can select a user from the modal.
The modal shows up. Click outside the modal or on the X button to close it.
Also try to insert an intro image but before you do so edit
so it become:
// This is for Mootools compatibility ?>parent.SqueezeBox.close();<?php endif ?>" data-dismiss="modal"><?php echo JText::_('JCANCEL') ?></button>
parent.SqueezeBox.close(); is the old way for the old mootools modals...
try to close the modal with the cancel button
Also try to insert an image and a module into tinyMCE
Switch to isis and repeat the whole process
What happened ?
you merged my PR against your branch,
but now, i see the old code, that is bogus, the latest changes are gone
both files, my original suggestion is bogus for 2 reasons:
i ll redo it later today 15 minutes to redo it, as i remember it, have a nice Sunday, thanks
nothing to redo, i found my branches, i had not deleted them yet )))
Tested various views with bootstrap / mootools modals,
Tested a few 3rd party extensions too
Tested also without tinymce editor
Tested with multiple tinymce editors
(modal closes and HTML goes into correct editor) this PR should not effect this, but tested anyway
I will mark a successful test tomorrow
|Status||New||⇒||Ready to Commit|