[#11095] - If the component do not provide the manifest file, the menu type is n…
- Closed
- 21 Jul 2016
- Medium
- Build: staging
- # 11095
- Diff
- Radek-Suski:master
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue none.
Moved the merge of the title outside the if (isset($vars['view'])) condition
Well, it's a bit silly but, install SobiPro, add a menu entry to any SobiPro functionality. If the menus entry is directly behind for example a menu entry to an article, the type of SobiPro menu entry will say: article >> single article
If you apply the fix it will say: SobiPro
| Category | ⇒ | Administration |
I have tested this item
This is a correct change based on reviewing. It's actually quite obvious if you know what the code is supposed to do
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11095.
By the way, looks like it's a bug I introduced, sorry
Thanks @Buddhima
@brianteeman it is not required. Although I think my description was a bit wrong. It won't work correctly when the component isn't using the "view" variable
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11095.
WTH? Thanks @Bakual. Weird
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11095.
I understand it know - the description was a bit weird
On 14 July 2016 at 14:10, Radek Suski notifications@github.com wrote:
WTH? Thanks @Bakual https://github.com/Bakual. Weird
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11095
https://issues.joomla.org/tracker/joomla-cms/11095.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11095 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8X8OUBWUfRg3qWiRKhEFDuU2eSrZks5qVjVEgaJpZM4JLL47
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11095.
| Status | New | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
wilsonge
-
Not sure I understand you. isn't the component supposed to have a manifest?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11095.