[#11080] - Fix secondary menu position if overflowing viewport
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 11080
- Diff
- C-Lodder:menufix
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11013.
Summary of Changes
Fixes the position of the secondary dropdown if it overflows the viewport height
Testing Instructions
First, ensure the "Banners" menu item is at the bottom of the "Components" dropdown, bu openening the following file ROOT/administrator/language/en-GB/en-GB.com_banners.sys.ini
and changing:
COM_BANNERS="Banners"
to:
COM_BANNERS="Zbanners"
Then ensure you're viewport height is relatively small. Before the patch, the secondary dropdown should look like this:
As you can see, it's overflowing the viewport height.
Once the patch is applied, the position will change so all menu items are visible.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (admin) UI/UX |
| Rel_Number | 0 | ⇒ | 11013 |
| Relation Type | ⇒ | Pull Request for |
Not really - you can fake it in the DB
On 13 July 2016 at 00:32, Dimitri Grammatikogianni <notifications@github.com
wrote:
Any suggestions for a component with pretty long second level menu to test
this?—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11080 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8ZTeknf5Fl0LyQ0WoDD5rIz3F__Aks5qVCQWgaJpZM4JK0HK
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11080.
I have applied this PR and tested with my custom component, and works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11080.
I have tested this item
I have tested successfully with Joomla Version: Joomla! 3.6.0 Stable [ Noether ] 12-July-2016 21:14 GMT
And system Windows 8.1, Browsers: Firefox 47.0.1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11080.
gunjanpatel
- | Status | Pending | ⇒ | Ready to Commit |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11080.
| Labels |
Added:
?
|
||
RTC
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 13:30:44 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Any suggestions for a component with pretty long second level menu to test this?