? Success

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
12 Jul 2016

Pull Request for Issue #10879 .

Summary of Changes

Enable TinyMCE Fullscreen mode

Testing Instructions

Apply patch - note new full screen menu option in tinymce editor - use it - test it

as proposed by @c-lodder in #10879 (cc: @brianteeman)

Milestone 3.6.1 please

avatar PhilETaylor PhilETaylor - open - 12 Jul 2016
avatar PhilETaylor PhilETaylor - change - 12 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2016
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 12 Jul 2016

This PR has a bug.. in so much as the top navbar that is fixed in Joomla hides the top menu bar of tinymce in full screen mode and therefore there is no way to come out of full screen mode in order to save the content with the joomla save button :-(

The PR therefore cannot be merged in its current state until this bug is fixed... but that probably needs a frontend JS/CSS guru and some funky z-index css rule or something :-( Beyond me this late at night :)

avatar C-Lodder
C-Lodder - comment - 12 Jul 2016

Cheers. I'll look at this after I've done the menu fix

avatar PhilETaylor
PhilETaylor - comment - 12 Jul 2016

find somewhere appropriate for this css and this fixes that overlay bug as the fixed navbar z-index is 1030

div.mce-fullscreen {
    z-index: 1031;
}
avatar brianteeman
brianteeman - comment - 12 Jul 2016

That's one reason I didn't implement it already Phil :)

On 12 Jul 2016 8:37 p.m., "Lodder" notifications@github.com wrote:

Cheers. I'll look at this after I've done the menu fix


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar PhilETaylor
PhilETaylor - comment - 12 Jul 2016

ready for testing :)

avatar C-Lodder
C-Lodder - comment - 12 Jul 2016

@PhilETaylor - CSS should be applied to the LESS files ;)

avatar PhilETaylor
PhilETaylor - comment - 12 Jul 2016

ah crap... like I said

that probably needs a frontend JS/CSS guru

200_s

avatar brianteeman brianteeman - change - 12 Jul 2016
Category Plugins
avatar PhilETaylor PhilETaylor - change - 13 Jul 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-07-13 00:56:33
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 13 Jul 2016

Add a Comment

Login with GitHub to post a comment