[#11048] - Fix tinyMCE modal close bug (again)
- Closed
- 11 Jul 2016
- Medium
- Build: staging
- # 11048
- Diff
- dgt41:tinyMCEFIX
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11047.
Testing Instructions
Follow these steps before and after applying this patch:
Add this snippet to administrator/components/com_content/models/forms/article.xml:
<field name="extrafield" type="editor"
label="An Extra Field" description="Whatever"
filter="JComponentHelper::filterText" buttons="true" />In administrator/components/com_content/views/article/tmpl/edit.php render the new field:
<?php echo $this->form->getInput('extrafield'); ?>Go to any media form field (the "Images and links" tab works for this), select an image, and try to close the modal in any available manner (the insert/cancel buttons, the X icon, or clicking outside the modal).
Expected result
The modal is closed.
Actual result
The modal does not close. In the browser console is a "Uncaught RangeError: Maximum call stack size exceeded" message.
Note:
The problem is the way the scripts added to the document and consequently executed. Ideal solution will be to load and execute the overrides for jModalClose and SqueezeBox.close last but that is impossible with current Joomla API, therefore the ugly code in the behaviour.php.
| Category | ⇒ | JavaScript Libraries |
This should be in J3.6.0 !
| Labels |
Added:
?
|
||
I have tested this item
Thank you! The problem is fixed.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048.
| Status | New | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048.
Manually added rtc label
| Milestone |
Added: |
||
Thanks for the info. I've tried to apply directly, but i don't find the exact node or place in the code to aply that.
Can'u explain where is the right place to put the snipet in article.xml and render the new field in edit.php? Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048.
I have tested this item✅ successfully on 262a4ae
Tested both
#10774 (tested Joomla article form)
#11047 (tested form with 2 tinymce editors, and custom code to open modal for selecting image)
Also tested bootstrap modals (associations)
And in the case of creating dynamically extra textareas and attaching tinymce, then in this case too, no problems
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048.