[#11040] - Use ajax power on module order field
- Fixed in Code Base
- 6 Sep 2016
- Medium
- Build: staging
- # 11040
- Diff
- dgt41:rfcModuleOrder
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Enhance the current status quo
Try to create a new module in module manager. Select a position. Select another position
The dropdown ordering doesn't really represent the true order of the modules in the new position.
So my idea was to use ajax power to be always accurate on that dropdown.
Summary of Changes
Use ajax power, tight connection with the controller module.php
Preview
Mind the untranslated string!
No other module in that position:
With other modules in the same position:
Testing
Please DO NOT TEST this one!
Instead give a vote (up or down thumb) so PLT can make a decision (or PLT decides directly, whatever comes first)
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration JavaScript |
@Devportobello from a UX perspective this is the right approach.
Now is this something that people actually use? I have no clue...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
I have applied this PR and try to create "custom" module, I have jQuery error in console.
Joomla Version: Joomla! 3.6.0-rc Release Candidate [ Noether ] 28-June-2016 20:34 GMT
Tested in Ubuntu 12.04, FireFox 47.0.1.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
I have tested after applying patch with Joomla Version Joomla! 3.6.0-rc Release Candidate [ Noether ] 28-June-2016 20:34 GMT in Windows 8.1, Firefox 47.0.1
Create new custom module and found jQuery error. Test with both case select unused position and used position.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
@RonakParmar @killoltailored Thanks for testing but this is RFC (Request for comments) which means a decision is needed here before I spent more time on this pr. So an up vote or down vote on the scope is enough at the moment (even if the code is not show time ready). Thanks again
Might have helped if you stated that!
@brianteeman I thought that RFC indicator was enough. Maybe I should have opened this as an issue without code attached so people wouldn't be able to do any testing.
Don't forget that we have a lot of less experienced developers and new
testers.
Never assume anything - when you assume you make a s ASS out of U and ME
I am sure they are testing it because they see pending status of the task. It is hard to understand what is RFC from the title of the task.
It isn't should be in a "Needs Review" status? Or may just "New" status and which waiting to be "Confirmed".
Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
Gunman. Unfortunately any PR will show up in patch tester. Patchtester only
shows if it is already RTC or not. Needs Review is an internal flag for CMS
maintainers to make a decision on something.
To be honest a comment that it didn't work is a reply to a request for a
comment in my book :)
Great idea. So who are you asking if this is worth it before working on this PR? The folks who manage PR's for new releases of Joomla? Testers?
@dgt41 - seems the consensus is that yes this is a good idea but that the code currently doesnt work yet
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
| Category | Administration JavaScript | ⇒ | Administration Components Layout Libraries JavaScript |
Now it should be testable
Can you remove RFC from title then?
| Title |
|
||||||
Not sure if it is doing what I expect it to do
After applying the patch the ordering in the select is correct but when viewing it on the front end the ordering selected is not being used
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
@brianteeman before applying this patch was the behaviour different? All this pr is doing is reloading the ordering when the position is changed, it shouldn't interfere with the actual ordering in the front end...
I have tested this item
No idea what the issue was I saw before as I cant replicate it now
I still dont really see what the difference is now though compared to before this pr
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
I have tested this item
I have tested this successfully. If we change the position then the ordering field fetches modules of the newly selected position.
But shouldn't Ordering dropdown be jQuery chosen dropdown as it was before this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
Hmm i have found two more ;)
| Status | Pending | ⇒ | Ready to Commit |
Go for it @joomla-cms-bot please make us happy
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 06:48:30 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Dunno if people use the ordering directly in edit mode, but this is an improvment when there is many module in same position