Joomla! Issue Tracker | Joomla! CMS #1103

Closed
17 Oct 2014
Medium
Build: master
# 1103
rlerdorf
5 May 2013
--------------------------------
File       : administrator/components/com_templates/models/source.php:234
Reason     : UseUndeclaredVariable
Snippet    : $table
Line       : $this->setError($table->getError());
--------------------------------
File       : components/com_tags/models/tag.php:260
Reason     : UseUndeclaredVariable
Snippet    : $id
Line       : if (empty($id))
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:2354
Reason     : UseUndeclaredVariable
Snippet    : $perms
Line       : @ftp_chmod($this->_handle, $perms, $remoteName);
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:2465
Reason     : UseUndeclaredVariable
Snippet    : $dir
Line       : $this->setError(AKText::sprintf('FTP_CANT_CREATE_DIR',$dir));
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:2537
Reason     : UseUndeclaredVariable
Snippet    : $path
Line       : return @ftp_chmod($this->handle, $perms, $path);
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:3182
Reason     : UseUndeclaredVariable
Snippet    : $retArray
Line       : $perms = $this->flagRestorePermissions ? $retArray['permissions'] : 0755;
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:4277
Reason     : UseUndeclaredVariable
Snippet    : $retArray
Line       : $perms = $this->flagRestorePermissions ? $retArray['permissions'] : 0755;
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:1629
Reason     : TooFewArgument
Snippet    : fread($fp)
Line       : $data = fread($fp);
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:1634
Reason     : TooFewArgument
Snippet    : fread($fp)
Line       : $data = fread($fp);
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:2333
Reason     : TooFewArgument
Snippet    : fopen($this->tempFilename)
Line       : $fp = @fopen($this->tempFilename);
--------------------------------
File       : administrator/components/com_joomlaupdate/restore.php:3873
Reason     : TooFewArgument
Snippet    : unpack('Vencsize/Vdecsize')
Line       : $miniHead = unpack('Vencsize/Vdecsize');
--------------------------------
File       : administrator/components/com_weblinks/controllers/weblink.php:117
Reason     : UseUndeclaredVariable
Snippet    : $task
Line       : if ($task == 'save')
--------------------------------
File       : installation/controller/removefolder.php:61
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : if (!isset($options->ftpEnable) || ($options->ftpEnable != 1))
--------------------------------
File       : installation/controller/removefolder.php:61
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : if (!isset($options->ftpEnable) || ($options->ftpEnable != 1))
--------------------------------
File       : installation/controller/removefolder.php:71
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $ftp = JClientFtp::getInstance($options->ftp_host, $options->ftp_port);
--------------------------------
File       : installation/controller/removefolder.php:71
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $ftp = JClientFtp::getInstance($options->ftp_host, $options->ftp_port);
--------------------------------
File       : installation/controller/removefolder.php:72
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $ftp->login($options->ftp_user, $options->ftp_pass);
--------------------------------
File       : installation/controller/removefolder.php:72
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $ftp->login($options->ftp_user, $options->ftp_pass);
--------------------------------
File       : installation/controller/removefolder.php:81
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $file = JPath::clean($options->ftp_root . '/joomla.xml');
--------------------------------
File       : installation/controller/removefolder.php:75
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $file = JPath::clean(str_replace(JPATH_CONFIGURATION, $options->ftp_root, $path), '/');
--------------------------------
File       : installation/controller/removefolder.php:91
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $robotsFile = JPath::clean($options->ftp_root . '/robots.txt');
--------------------------------
File       : installation/controller/removefolder.php:92
Reason     : UseUndeclaredVariable
Snippet    : $options
Line       : $distFile = JPath::clean($options->ftp_root . '/robots.txt.dist');
--------------------------------
File       : administrator/components/com_menus/models/item.php:1128
Reason     : UseUndeclaredVariable
Snippet    : $error
Line       : $this->setError($error);
--------------------------------
File       : components/com_contact/helpers/icon.php:50
Reason     : UseUndeclaredVariable
Snippet    : $contact
Line       : $url  = ContentHelperRoute::getContactRoute($contact->slug, $contact->catid);
--------------------------------
File       : components/com_contact/helpers/icon.php:50
Reason     : UseUndeclaredVariable
Snippet    : $contact
Line       : $url  = ContentHelperRoute::getContactRoute($contact->slug, $contact->catid);
--------------------------------
File       : components/com_contact/helpers/icon.php:51
Reason     : UseUndeclaredVariable
Snippet    : $request
Line       : $url .= '&tmpl=component&print=1&layout=default&page='.@ $request->limitstart;
--------------------------------
File       : libraries/joomla/database/importer/postgresql.php:221
Reason     : TooManyArgument
Snippet    : $this->getChangeSequenceSQL($kSeqName, $vSeq)
Line       : $alters[] = $this->getChangeSequenceSQL($kSeqName, $vSeq);
--------------------------------
File       : modules/mod_articles_category/helper.php:364
Reason     : RequiredAfterOptionalParam
Snippet    : $type = 'year'
Line       : public static function groupByDate($list, $type = 'year', $article_grouping_direction, $month_year_format = 'F Y')
--------------------------------
File       : administrator/components/com_redirect/helpers/html/redirect.php:28
Reason     : RequiredAfterOptionalParam
Snippet    : $value = 0
Line       : public static function published($value = 0, $i, $canChange = true)
--------------------------------
File       : administrator/components/com_messages/helpers/html/messages.php:23
Reason     : RequiredAfterOptionalParam
Snippet    : $value = 0
Line       : public static function state($value = 0, $i, $canChange)
--------------------------------
File       : administrator/components/com_contact/helpers/html/contact.php:96
Reason     : RequiredAfterOptionalParam
Snippet    : $value = 0
Line       : public static function featured($value = 0, $i, $canChange = true)
--------------------------------
File       : administrator/components/com_content/helpers/html/contentadministrator.php:95
Reason     : RequiredAfterOptionalParam
Snippet    : $value = 0
Line       : public static function featured($value = 0, $i, $canChange = true)
--------------------------------
File       : libraries/cms/html/sortablelist.php:41
Reason     : RequiredAfterOptionalParam
Snippet    : $sortDir = 'asc'
Line       : public static function sortable($tableId, $formId, $sortDir = 'asc', $saveOrderingUrl, $proceedSaveOrderButton = true, $nestedList = false)
--------------------------------
File       : libraries/legacy/component/helper.php:256
Reason     : TooFewArgument
Snippet    : array_diff($filter->attrBlacklist)
Line       : $filter->attrBlacklist = array_diff($filter->attrBlacklist);
--------------------------------
File       : libraries/joomla/language/language.php:736
Reason     : TooManyArgument
Snippet    : $this->loadLanguage($filename, $extension, false)
Line       : $result = $this->loadLanguage($filename, $extension, false);
--------------------------------
File       : libraries/legacy/base/tree.php:48
Reason     : TooManyArgument
Snippet    : new JNode('ROOT')
Line       : $this->_root = new JNode('ROOT');
--------------------------------
File       : components/com_content/helpers/association.php:37
Reason     : TooManyArgument
Snippet    : jimport('helper.route', JPATH_COMPONENT_SITE)
Line       : jimport('helper.route', JPATH_COMPONENT_SITE);
--------------------------------
File       : components/com_weblinks/helpers/association.php:37
Reason     : TooManyArgument
Snippet    : jimport('helper.route', JPATH_COMPONENT_SITE)
Line       : jimport('helper.route', JPATH_COMPONENT_SITE);
--------------------------------
File       : administrator/components/com_users/models/group.php:127
Reason     : TooManyArgument
Snippet    : JAccess::getAssetRules('root.1')->getData('core.admin')
Line       : $rules = JAccess::getAssetRules('root.1')->getData('core.admin');
--------------------------------
File       : build/libraries/less/lessc.php:2987
Reason     : TooManyArgument
Snippet    : $this->interpolation($inter, false)
Line       : if ($this->interpolation($inter, false))
--------------------------------
File       : libraries/joomla/database/iterator.php:101
Reason     : TooManyArgument
Snippet    : $this->freeResult($this->cursor)
Line       : $this->freeResult($this->cursor);
--------------------------------
File       : administrator/components/com_categories/helpers/association.php:43
Reason     : TooManyArgument
Snippet    : jimport('helper.route', JPATH_COMPONENT_SITE)
Line       : jimport('helper.route', JPATH_COMPONENT_SITE);
--------------------------------
File       : libraries/cms/form/field/helpsite.php:42
Reason     : TooManyArgument
Snippet    : JHelp::createSiteList(JPATH_ADMINISTRATOR . '/help/helpsites.xml', $this->value)
Line       : $options = array_merge(parent::getOptions(), JHelp::createSiteList(JPATH_ADMINISTRATOR . '/help/helpsites.xml', $this->value));
--------------------------------
File       : components/com_newsfeeds/helpers/association.php:37
Reason     : TooManyArgument
Snippet    : jimport('helper.route', JPATH_COMPONENT_SITE)
Line       : jimport('helper.route', JPATH_COMPONENT_SITE);
--------------------------------
File       : administrator/components/com_languages/models/languages.php:118
Reason     : TooManyArgument
Snippet    : $this->getState('list.select', 'a.*', 'l.home')
Line       : $query->select($this->getState('list.select', 'a.*', 'l.home'))
--------------------------------
File       : components/com_contact/helpers/association.php:37
Reason     : TooManyArgument
Snippet    : jimport('helper.route', JPATH_COMPONENT_SITE)
Line       : jimport('helper.route', JPATH_COMPONENT_SITE);
--------------------------------
File       : libraries/cms/installer/adapter/component.php:510
Reason     : TooManyArgument
Snippet    : $this->_buildAdminMenus($row->extension_id)
Line       : if (!$this->_buildAdminMenus($row->extension_id))
--------------------------------
File       : libraries/cms/installer/adapter/component.php:848
Reason     : TooManyArgument
Snippet    : $this->_buildAdminMenus($eid)
Line       : if (!$this->_buildAdminMenus($eid))
--------------------------------
File       : libraries/cms/installer/adapter/component.php:1776
Reason     : TooManyArgument
Snippet    : $this->_buildAdminMenus($this->parent->extension->extension_id)
Line       : if (!$this->_buildAdminMenus($this->parent->extension->extension_id))
--------------------------------
File       : libraries/cms/installer/adapter/component.php:1536
Reason     : BadPassByReference
Snippet    : (object)array('extension_id' => $step['id'])
Line       : return $this->_removeAdminMenus((object) array('extension_id' => $step['id']));
--------------------------------
File       : libraries/joomla/google/embed/maps.php:39
Reason     : BadArgumentType
Snippet    : parameter 2 of __construct() requires Object - juri, called with [0x1]
Line       : parent::__construct($options = null, $uri = null);
--------------------------------
File       : administrator/components/com_finder/controllers/indexer.json.php:43
Reason     : UseVoidReturn
Snippet    : JLog::addLogger($options)
Line       : $log = JLog::addLogger($options);
--------------------------------
File       : administrator/components/com_finder/controllers/indexer.json.php:110
Reason     : UseVoidReturn
Snippet    : JLog::addLogger($options)
Line       : $log = JLog::addLogger($options);
--------------------------------
File       : administrator/components/com_finder/controllers/indexer.json.php:278
Reason     : UseVoidReturn
Snippet    : JLog::addLogger($options)
Line       : $log = JLog::addLogger($options);
--------------------------------
File       : administrator/components/com_finder/controllers/indexer.json.php:332
Reason     : UseVoidReturn
Snippet    : JLog::addLogger($options)
Line       : $log = JLog::addLogger($options);
--------------------------------
File       : administrator/components/com_joomlaupdate/models/default.php:397
Reason     : BadPassByReference
Snippet    : 'order deny, allow'."\n".'deny from all'."\n".'allow from none'."\n"
Line       : JFile::write($tempdir . '/.htaccess', "order deny, allow\ndeny from all\nallow from none\n");
rlerdorf - open - 5 May 2013
elinw - comment - 6 May 2013
Thanks so much, the bug squad will carefully work its way through these. Unfortunately we are somewhat stuck with the not optimal ordering of arguments since there are many users of the methods.
Thanks so much for the report.
vdespa - comment - 13 Sep 2014
Thanks for your bug report. As the issue is more than a year old, is possible that some of them have been resolved. Manually checking all of them requires some times.
What tools did you use to use to generate this report?

This comment was created with the J!Tracker Application at http://issues.joomla.org/.
vdespa - change - 13 Sep 2014
Add a Comment

Older
Newer
Status	New	⇒	Information Required
Build		⇒	n/a
Joomla! Issue Tracker - CMS

[#1103] - Static Analysis Results

Add a Comment
