[#1102] - Fix some mistakes
- Closed
- 8 Oct 2014
- Medium
- Build: master
- # 1102
- Diff
- rlerdorf:master
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
Did a static analysis run and fixed a few of the issues it found. I will file bugs for the remainder.
Sorry, I don't have time to fiddle with multiple bug trackers. Go ahead and do whatever you need to do.
No problem; I completely understand. I went ahead and submitted the tracker item for you:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30870
Thanks again, Rasmus!
Thanks all looks good here
I have separated the languagefilter Notice issue as patch is no good.
Corrected it and created a new tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30873
We had to make a few changes where the right code was not obvious.
brianteeman
- | Status | New | ⇒ | Pending |
| Build | ⇒ | . |
All the various issues have since been commited in core and this PR can now be closed. Thank you for all the fixes! It's very much appreciated
phproberto
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-08 12:13:21 |
Thanks for coding this, Rasmus!
While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to the other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues
Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.
Thanks in advance and thanks again for coding this, Rasmus!