Feeling Lucky
?
?
[#11023] - Make JAuthentication autoloaded, split 2 classes to 2 files
- Closed
- 30 Jul 2016
- Medium
- Build: staging
- # 11023
- Diff
- mbabker:move-authentication-classes
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The JAuthentication class requires manual import and the file that holds this class contains two classes (JAuthentication and JAuthenticationResponse). Move the file so it can be autoloaded and split the response class to a new file to follow the one class per file convention.
Testing Instructions
User authentication still works correctly, on update the old file is deleted.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
brianteeman
- | Category | ⇒ | Libraries Unit Tests |
| Labels | |||
| Category | Libraries Unit Tests | ⇒ | Authentication Libraries Unit Tests |
rahultomar
- comment
- 14 Jul 2016
I have not tested this item.
Tested , and working fine
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023.
rahultomar
- comment
- 14 Jul 2016
I have tested this item
Tested , and working fine
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023.
| Status | Pending | ⇒ | Ready to Commit |
gunjanpatel
- comment
- 15 Jul 2016
| Labels |
Added:
?
|
||
roland-d
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 14:08:19 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 3233daa
I have Joomla Authentication Plugin enabled and user authentication works correctly after applying patch too.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023.