? Success
Pull Request for # 11020

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
4 Jul 2016

Pull Request for Issue #11020 .

Summary of Changes

This patch deactivates the TinyMCE filtering, if the editor has "No filtering" in the global configuration (Tab Text filter)

Testing Instructions

  • Login as Super User
  • Make sure, you have "No filtering" in the text filter settings (global config)
  • Switch the filter in the tinymce plugin to "Use Joomla text filter"
  • Add <span class="fa fa-phone fa-3x sr-contact"></span> <p>123-456-6789</p> to a article
  • Toggle editor
    => Code is removed
  • Apply patch
  • Try again

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar bembelimen bembelimen - open - 4 Jul 2016
avatar bembelimen bembelimen - change - 4 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 4 Jul 2016
Rel_Number 0 11020
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 4 Jul 2016
Category Plugins
avatar brianteeman brianteeman - test_item - 4 Jul 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 4 Jul 2016

I have tested this item ? unsuccessfully on f85ad0e

I can confirm the issue as reported

But after applying the patch and toggling the editor and pasting the following code
<span class="fa fa-phone fa-3x sr-contact"></span> <p>123-456-6789</p>

When I toggle the editor back on and then off again it shows

<p><span class="fa fa-phone fa-3x sr-contact"></span></p>
<p>123-456-6789</p>

Note the extra < p >


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

avatar bembelimen
bembelimen - comment - 4 Jul 2016

That's (sadly) a standard behavior in the tinymce. If you toggle the editor (to html) insert some text, toggle it back and look again, it also added the <p>

See also: https://www.tinymce.com/docs/configure/content-filtering/#forced_root_block

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Jul 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

avatar designbengel designbengel - test_item - 4 Jul 2016 - Tested successfully
avatar designbengel
designbengel - comment - 4 Jul 2016

I have tested this item successfully on 7fd9073


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

avatar designbengel
designbengel - comment - 4 Jul 2016

@brianteeman if you turn off <p> for new lines in the tinyMCE Plugin it doesn´t add the additional p
I see this fix as important to be merged because otherwise everything is striped by default?

avatar yvesh
yvesh - comment - 4 Jul 2016

@bembelimen either i don't get the PR or you interchanged true and false. Not working for me.

Added some var_dumps and the output of verify_html for your reference:

screenshot 2016-07-04 21 36 29

avatar bembelimen
bembelimen - comment - 4 Jul 2016

Hi @yvesh
It's a bit tricky: to deactivate the filtering in the TinyMCE, you have to set verify_html to "false".
So if $ignore_filter is "true", I had to flip verify_html to false. And ofc the other way arround, too.

avatar yvesh
yvesh - comment - 4 Jul 2016

Okay, sorry my fault. Should read the instruction properly (forgot switching to joomla filter in plugin settings).

avatar yvesh yvesh - test_item - 4 Jul 2016 - Tested successfully
avatar yvesh
yvesh - comment - 4 Jul 2016

I have tested this item successfully on 7fd9073

Works fine, thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

avatar designbengel
designbengel - comment - 4 Jul 2016

@wilsonge can you merge this?

avatar brianteeman brianteeman - change - 4 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 4 Jul 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 4 Jul 2016
avatar brianteeman brianteeman - change - 12 Jul 2016
Milestone Added:
avatar roland-d roland-d - reference | 14098e7 - 16 Jul 16
avatar roland-d roland-d - merge - 16 Jul 2016
avatar roland-d roland-d - close - 16 Jul 2016
avatar zero-24
zero-24 - comment - 21 Jul 2016

@joomla-cms-bot you record i need to call you twice on one issue for that label thing :P

Add a Comment

Login with GitHub to post a comment