[#10995] - url field using jlayout
- Closed
- 30 Jul 2016
- Medium
- Build: staging
- # 10995
- Diff
- dgt41:+Field_url
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Separate logic/ output
Base work for future templates update etc..
Summary of Changes
Introduce a layout for this field
Testing Instructions
Apply patch and rename any backend input to url
eg
<field name="mytextvalue" type="url" default="Some text" label="Enter some text" description="" size="10" />Also consult: https://docs.joomla.org/Standard_form_field_types
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @brianteeman, @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
This PR has received new commits.
CC: @brianteeman, @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Remove RTC for now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
| Labels |
Removed:
?
|
||
@JoomliC actually to do such changes we need to change the unit tests as well. We should do that, but lets take the small steps approach
I understand, indeed already many issue with UT...
So, maybe need a plan to update UT as well as code standards for attributes ordering rules (as not clear yet)
@JoomliC check #10984 (comment) it sounds solid, but I have messed up my local env so cannot tested and do the relevant changes. Will try to fix my pc this weekend and then try to apply all these changes
@dgt41 To be honnest, not an expert with Joomla UT, never used it...
But if the change could allow you to do as you did in the first try, it would be great as it was nicer to read code in your first attempt than it is currently (and if in the same time, this UT change could allow ordering, maybe a way to set standards ?) ;-)
| Category | Layout | ⇒ | Layout Unit Tests |
| Labels | |||
| Labels | |||
This PR has received new commits.
CC: @brianteeman, @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
Reverted the last two commits that broke the unit tests. UT should be rewritten, but not in this pr
| Status | Pending | ⇒ | Ready to Commit |
This PR has received new commits.
CC: @brianteeman, @RonakParmar
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10995.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 21:12:27 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@JoomliC actually to do such changes we need to change the unit tests as well. We should do that, but lets take the small steps approach